mirrors/git-repo
1
0
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2026-05-31 15:09:48 +00:00
Code Issues Projects Releases Wiki Activity

command: Move smart sync override logic to Command base class

Browse Source 
Deduplicate the logic for loading `smart_sync_override.xml` by
moving it from `forall.py` to the `Command` base class. This allows
other commands to reuse it to respect smart tags.

Bug: 279204331
Change-Id: I6f2f03995266c2a68c3225cacb92b2f580a89178
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/582502
Tested-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
This commit is contained in:
Gavin Mak
2026-05-12 20:21:10 +00:00
committed by gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com
parent 0129ac1c46
commit d453273f06
3 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
subcmds/forall.py
+1 -7
View File
@@ -242,13 +242,7 @@ without iterating through the remaining projects.
mirror = self.manifest.IsMirror
smart_sync_manifest_name = "smart_sync_override.xml"
smart_sync_manifest_path = os.path.join(
self.manifest.manifestProject.worktree, smart_sync_manifest_name
)
if os.path.isfile(smart_sync_manifest_path):
self.manifest.Override(smart_sync_manifest_path)
self.TryOverrideManifestWithSmartSync()
if opt.regex:
projects = self.FindProjects(args, all_manifests=all_trees)
subcmds/sync.py
+1 -3
View File
@@ -2050,9 +2050,7 @@ later is required to fix a server side protocol bug.
manifest.Override(opt.manifest_name)
manifest_name = opt.manifest_name
smart_sync_manifest_path = os.path.join(
manifest.manifestProject.worktree, "smart_sync_override.xml"
)
smart_sync_manifest_path = self.GetSmartSyncOverridePath(manifest)
if opt.clone_bundle is None:
opt.clone_bundle = manifest.CloneBundle