Mike Frysinger
cc1f41d782
style: use import repo_logging everywhere
...
Align with Google style guides and `import repo_logging` as a module
rather than import symbols out of it.
Change-Id: Ie13c1f13be00dbf6dd3814a8780baf6453972237
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/647823
Tested-by: Mike Frysinger <vapier@google.com >
Commit-Queue: Mike Frysinger <vapier@google.com >
Reviewed-by: Brian Gan <brgan@google.com >
2026-10-23 09:49:36 -07:00
Mike Frysinger
2c04b98c60
style: use import error everywhere
...
Align with Google style guides and `import error` as a module rather
than import classes out of it.
Change-Id: I8686fbe7887bd6ceac7a07877af63934f0d0ddd2
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/647563
Commit-Queue: Mike Frysinger <vapier@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Insaf Latypov <saferif@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2026-10-22 17:44:11 -07:00
Mike Frysinger
06338abe79
subcmds: delete redundant dest= settings
...
Add a test to enforce this too.
Change-Id: I80b5cf567aa33db9c24b53428c66d69f9c1d8d74
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/478481
Commit-Queue: Mike Frysinger <vapier@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
Reviewed-by: Scott Lee <ddoman@google.com >
2025-05-27 09:26:43 -07:00
Aravind Vasudevan
c993c5068e
subcmds: Use repo logger
...
Bug: b/292704435
Change-Id: Ia3a45d87fc0bf0d4a1ba53050d9c3cd2dba20e55
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/386236
Reviewed-by: Jason Chang <jasonnc@google.com >
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com >
Tested-by: Aravind Vasudevan <aravindvasudev@google.com >
2023-09-14 17:13:37 +00:00
Mike Frysinger
6447733eb2
isort: format codebase
...
Change-Id: I6f11d123b68fd077f558d3c21349c55c5f251019
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/383715
Reviewed-by: Gavin Mak <gavinmak@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
Commit-Queue: Mike Frysinger <vapier@google.com >
2023-08-22 18:32:22 +00:00
Mike Frysinger
06ddc8c50a
tweak stdlib imports to follow Google style guide
...
Google Python style guide says to import modules.
Clean up all our stdlib imports. Leave the repo ones alone
for now as that's a much bigger shave.
Change-Id: Ida42fc2ae78b86e6b7a6cbc98f94ca04b295f8cc
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/383714
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Mike Frysinger <vapier@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2023-08-22 18:22:49 +00:00
Jason Chang
1a3612fe6d
Raise RepoExitError in place of sys.exit
...
Bug: b/293344017
Change-Id: Icae4932b00e4068cba502a5ab4a0274fd7854d9d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/382214
Reviewed-by: Gavin Mak <gavinmak@google.com >
Tested-by: Jason Chang <jasonnc@google.com >
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Commit-Queue: Jason Chang <jasonnc@google.com >
2023-08-10 23:46:31 +00:00
Gavin Mak
ea2e330e43
Format codebase with black and check formatting in CQ
...
Apply rules set by https://gerrit-review.googlesource.com/c/git-repo/+/362954/ across the codebase and fix any lingering errors caught
by flake8. Also check black formatting in run_tests (and CQ).
Bug: b/267675342
Change-Id: I972d77649dac351150dcfeb1cd1ad0ea2efc1956
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/363474
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2023-03-22 17:46:28 +00:00
LaMont Jones
1eddca8476
sync: use namedtuples for internal return values
...
Replace tuple returns with namedtuples, to simplify adding new fields.
Extend the Sync_NetworkHalf return value to:
- success: True if successful (the former return value)
- remote_fetched: True if we called `git fetch`
Change-Id: If63c24c2f849523f77fa19c05bbf23a5e9a20ba9
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/344534
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: LaMont Jones <lamontjones@google.com >
2022-09-19 22:03:18 +00:00
Mike Frysinger
4f21054c28
commands: document the "common" class attribute
...
Switch it to uppercase to make it clear it's a constant, and add
documentation so its usage is clear.
Change-Id: I6d281a66a90b5908b3131585c9945e88cfe815ea
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/309322
Reviewed-by: Raman Tenneti <rtenneti@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2021-06-15 06:07:37 +00:00
Mike Frysinger
784ccfc040
strip python2-only coding:utf-8 & print_function settings
...
We're committed to Python 3 at this point, so clean up boilerplate.
Bug: https://crbug.com/gerrit/10418
Change-Id: Ib1719ba2eb65c53b94881a1a1bf203ddfcaaafed
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292382
Reviewed-by: Chris Mcdonald <cjmcdonald@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2021-01-06 18:53:05 +00:00
Mike Frysinger
c58ec4dba1
avoid negative variables
...
Trying to use booleans with names like "no_xxx" are hard to follow due
to the double negatives. Invert all of them so we only have positive
meanings to follow.
Change-Id: Ifd37d0368f97034d94aa2cf38db52c723ac0c6ed
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255493
Tested-by: Mike Frysinger <vapier@google.com >
Reviewed-by: David Pursehouse <dpursehouse@collab.net >
2020-02-19 00:24:43 +00:00
David Pursehouse
819827a42d
Fix blank line issues reported by flake8
...
- E301 expected 1 blank line
- E302 expected 2 blank lines
- E303 too many blank lines
- E305 expected 2 blank lines after class or function definition
- E306 expected 1 blank line before a nested definition
Fixed automatically with autopep8:
git ls-files | grep py$ | xargs autopep8 --in-place \
--select E301,E302,E303,E305,E306
Manually fix issues in project.py caused by misuse of block comments.
Change-Id: Iee840fcaff48aae504ddac9c3e76d2acd484f6a9
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254599
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: David Pursehouse <dpursehouse@collab.net >
2020-02-12 06:36:40 +00:00
David Pursehouse
e5913ae410
Fix flake8 E251 unexpected spaces around keyword / parameter equals
...
Fixed automatically with autopep8:
git ls-files | grep py$ | xargs autopep8 --in-place --select E251
Change-Id: I58009e1c8c91c39745d559ac919be331d4cd9e77
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254598
Tested-by: David Pursehouse <dpursehouse@collab.net >
Reviewed-by: Mike Frysinger <vapier@google.com >
2020-02-12 05:17:08 +00:00
Mike Frysinger
f601376e13
set default file encoding to utf-8
...
There's no reason to support any other encoding in these files.
This only affects the files themselves and not streams they open.
Bug: https://crbug.com/gerrit/10418
Change-Id: I053cb40cd3666ce5c8a0689b9dd938f24ca765bf
2019-06-13 14:30:52 +00:00
Sarah Owens
cecd1d864f
Change print statements to work in python3
...
This is part of a series of changes to introduce Python3 support.
Change-Id: I373be5de7141aa127d7debdbce1df39148dbec32
2012-11-13 17:33:56 -08:00
Shawn O. Pearce
0d2b61f11d
sync: Run git gc --auto after fetch
...
Users may wind up with a lot of loose object content in projects they
don't frequently make changes in, but that are modified by others.
Since we bypass many git code paths that would have otherwise called
out to `git gc --auto`, its possible for these projects to have
their loose object database grow out of control. To help prevent
that, we now invoke it ourselves during the network half of sync.
Signed-off-by: Shawn O. Pearce <sop@google.com >
(cherry picked from commit 1875ddd47c )
2011-01-09 17:39:22 -08:00
Shawn O. Pearce
fd89b67f5c
Clarify options that control the repo executable version
...
Signed-off-by: Shawn O. Pearce <sop@google.com >
2009-04-18 11:28:57 -07:00
Shawn O. Pearce
e756c412e3
Add 'repo selfupdate' to upgrade only repo
...
Users may want to upgrade only repo to the latest release, but
leave their working tree state alone and avoid 'repo sync'.
Signed-off-by: Shawn O. Pearce <sop@google.com >
2009-04-13 11:53:53 -07:00