mirror of
https://gerrit.googlesource.com/git-repo
synced 2026-09-21 14:20:29 +00:00
Josef Malmström
978adb7ea5
A global setting for disabling fetching of submodules is useful since this can currently otherwise only be done by modifying the manifest, or by explicitly providing projects on command line. Add this setting as --no-fetch-submodules to mirror the existing --fetch-submodules. Change-Id: Ic727c54f11a594aa52315751284b87138cf246bb Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/607641 Commit-Queue: Josef Malmstrom <Josef.Malmstrom@arm.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Tested-by: Josef Malmstrom <Josef.Malmstrom@arm.com> Reviewed-by: Mike Frysinger <vapier@google.com>
120 lines
3.2 KiB
Python
120 lines
3.2 KiB
Python
# Copyright (C) 2026 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Unittests for the command.py module."""
|
|
|
|
import pytest
|
|
|
|
from command import Command
|
|
|
|
|
|
class FakeProject:
|
|
"""Minimal project double for Command.GetProjects tests."""
|
|
|
|
def __init__(
|
|
self,
|
|
name,
|
|
relpath,
|
|
*,
|
|
gitdir=None,
|
|
derived_subprojects=None,
|
|
sync_s=False,
|
|
):
|
|
self.name = name
|
|
self.relpath = relpath
|
|
self.gitdir = gitdir or f"/git/{relpath}"
|
|
self.sync_s = sync_s
|
|
self.Exists = True
|
|
self._derived_subprojects = derived_subprojects or []
|
|
|
|
def GetDerivedSubprojects(self):
|
|
return list(self._derived_subprojects)
|
|
|
|
def MatchesGroups(self, _groups):
|
|
return True
|
|
|
|
def RelPath(self, local=True):
|
|
return self.relpath
|
|
|
|
|
|
class FakeManifest:
|
|
"""Minimal manifest double for Command.GetProjects tests."""
|
|
|
|
def __init__(self, projects):
|
|
self.projects = projects
|
|
|
|
def GetManifestGroupsStr(self):
|
|
return "default"
|
|
|
|
|
|
def test_get_projects_keeps_derived_subprojects_for_repeated_repo():
|
|
"""Derived subprojects are keyed by checkout path, not repo identity."""
|
|
submodule_a = FakeProject(
|
|
"submodule",
|
|
"src/one/submodule",
|
|
gitdir="/shared/modules/submodule.git",
|
|
)
|
|
submodule_b = FakeProject(
|
|
"submodule",
|
|
"src/two/submodule",
|
|
gitdir="/shared/modules/submodule.git",
|
|
)
|
|
project_a = FakeProject(
|
|
"project",
|
|
"src/one",
|
|
derived_subprojects=[submodule_a],
|
|
sync_s=True,
|
|
)
|
|
project_b = FakeProject(
|
|
"project",
|
|
"src/two",
|
|
derived_subprojects=[submodule_b],
|
|
sync_s=True,
|
|
)
|
|
manifest = FakeManifest([project_a, project_b])
|
|
cmd = Command(manifest=manifest)
|
|
|
|
projects = cmd.GetProjects([])
|
|
|
|
assert set(projects) == {project_a, project_b, submodule_a, submodule_b}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"submodules_ok, sync_s, includes_submodule",
|
|
[
|
|
(None, False, False),
|
|
(None, True, True),
|
|
(True, False, True),
|
|
(True, True, True),
|
|
(False, False, False),
|
|
(False, True, False),
|
|
],
|
|
)
|
|
def test_get_projects_submodule_override(
|
|
submodules_ok, sync_s, includes_submodule
|
|
):
|
|
"""The CLI override takes precedence over a project's sync-s setting."""
|
|
submodule = FakeProject("submodule", "project/submodule")
|
|
project = FakeProject(
|
|
"project",
|
|
"project",
|
|
derived_subprojects=[submodule],
|
|
sync_s=sync_s,
|
|
)
|
|
cmd = Command(manifest=FakeManifest([project]))
|
|
|
|
projects = cmd.GetProjects([], submodules_ok=submodules_ok)
|
|
|
|
assert (submodule in projects) is includes_submodule
|