From 45266372501656233dc9b409d8391ebde1d61e4d Mon Sep 17 00:00:00 2001 From: Gyorgy Szing Date: Thu, 23 Apr 2026 17:37:21 +0200 Subject: [PATCH] scripts/runfvp: fix exception handling Returning from the finally block at the end of the start_fvp() function is discarding exceptions. Since start_fvp() is near to the top off the call tree, this hides uncaught exceptions thrown by most of the code, which makes detecting and debugging issues hard. This is resolved by removing the return statement from the finally block, allowing exceptions to propagate normally. Signed-off-by: Gyorgy Szing Signed-off-by: Jon Mason --- scripts/runfvp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/runfvp b/scripts/runfvp index 8e6fe655..10a8ad1c 100755 --- a/scripts/runfvp +++ b/scripts/runfvp @@ -86,8 +86,9 @@ def start_fvp(args, fvpconf, extra_args): except FileNotFoundError as e: logger.error(f"FVP executable not found ({e})") finally: - return fvp.stop() + rv=fvp.stop() + return rv def runfvp(cli_args): args, extra_args = parse_args(cli_args)