mirrors/meta-arm
1
0
Fork 0
mirror of https://git.yoctoproject.org/meta-arm synced 2026-05-30 12:30:14 +00:00
Code Issues Projects Releases Wiki Activity

external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES

Browse Source 
There's no need to directly provide binutils-cross-${TARGET_ARCH}, as the
PROVIDES list already contains virtual/${TARGET_PREFIX}binutils and correct
PREFERRED_PROVIDER is set in the corresponding tcmode-external-arm.inc file:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}binutils = "external-arm-toolchain"

Similar to the compiler:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-initial = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}g++ = "external-arm-toolchain"

And similar to glibc:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-for-gcc = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}compilerlibs = "external-arm-toolchain"

There shouldn't be any direct dependency on binutils-cross-${TARGET_ARCH}. And
if there is, it needs to be fixed to depend on virtual/${TARGET_PREFIX}binutils

During 8.x upgrade there was an attempt to clean it up:

https://git.linaro.org/openembedded/meta-linaro.git/commit/meta-linaro-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb?id=a8ce3dc47f3be9f98abc6ac98a849f918386cf9f

But unfortunately, it got re-added back w/o reasoning:

https://git.linaro.org/openembedded/meta-linaro.git/commit/?id=bb04bc8c67fd032fe04c47b2163ea5fa6b2ffa86

Also, while at it, fix indentation for glibc-mtrace in PROVIDES list.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
Signed-off-by: Jon Mason <jon.mason@arm.com>
This commit is contained in:
Denys Dmytriyenko
2020-04-30 00:10:26 -04:00
committed by Jon Mason
parent 8aaba503d3
commit efd0773165
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
+1 -2
View File
@@ -15,14 +15,13 @@ PROVIDES += "\
virtual/${TARGET_PREFIX}g++ \ virtual/${TARGET_PREFIX}g++ \
virtual/${TARGET_PREFIX}gcc-initial \ virtual/${TARGET_PREFIX}gcc-initial \
virtual/${TARGET_PREFIX}binutils \ virtual/${TARGET_PREFIX}binutils \
binutils-cross-${TARGET_ARCH} \
virtual/${TARGET_PREFIX}libc-for-gcc \ virtual/${TARGET_PREFIX}libc-for-gcc \
virtual/${TARGET_PREFIX}compilerlibs \ virtual/${TARGET_PREFIX}compilerlibs \
virtual/libc \ virtual/libc \
virtual/libintl \ virtual/libintl \
virtual/libiconv \ virtual/libiconv \
virtual/crypt \ virtual/crypt \
glibc-mtrace \ glibc-mtrace \
glibc-thread-db \ glibc-thread-db \
glibc \ glibc \
libc-mtrace \ libc-mtrace \