From e1d3b9598e3a149f6f5ca323503b6e745dedf66d Mon Sep 17 00:00:00 2001 From: Adam Duskett Date: Tue, 17 Feb 2026 16:41:37 +0100 Subject: [PATCH] libtoml11/files/run-ptest: cleanup Shellcheck -oall warnings fixed: - exit 1 if `cd tests` failes (SC2164) - Double quote `./${atest}` to prevent globbing and word splitting. (SC2086) - Check the test exit code directly intead of using $? (SC2181) Other fixes: - The shebang sould traditionally be /usr/bin/env sh in case sh is not located in /bin. - Do not remove tests.log for every test. Signed-off-by: Adam Duskett Signed-off-by: Khem Raj --- meta-oe/recipes-devtools/libtoml11/files/run-ptest | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/meta-oe/recipes-devtools/libtoml11/files/run-ptest b/meta-oe/recipes-devtools/libtoml11/files/run-ptest index 9bc480aa7f..4da9e68cc5 100755 --- a/meta-oe/recipes-devtools/libtoml11/files/run-ptest +++ b/meta-oe/recipes-devtools/libtoml11/files/run-ptest @@ -1,10 +1,11 @@ -#!/bin/sh +#!/usr/bin/env sh + +cd tests || exit 1 + +rm -rf tests.log -cd tests for atest in test_* ; do - rm -rf tests.log - ./${atest} > tests.log 2>&1 - if [ $? = 0 ] ; then + if ./"${atest}" >> tests.log 2>&1; then echo "PASS: ${atest}" else echo "FAIL: ${atest}"