32 Commits

Author SHA1 Message Date
Chong.Lu@windriver.com d6f4b66e3f quagga: remove watchquagga when start with systemd
When we start with sysvinit, watchquagga uses quagga init script to
monitor zebra daemon. But we need not do this in systemd environment.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2014-10-21 14:23:25 -04:00
Chong.Lu@windriver.com 07e13c6b94 quagga: add systemd service file
Add systemd service for quagga.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-10-04 00:30:29 +02:00
Chong.Lu@windriver.com a97b89e72f quagga: add subpkgs to RDEPENDS
We need subpkgs to start quagga, so add them to RDEPENDS.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-10-04 00:30:29 +02:00
Roy Li 8a428b570d quagga: uprev it to 0.99.23
uprev it to 0.99.23
remove patches which have been in the latest version

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-08-13 23:28:06 +02:00
Yue Tao 71bb2dc7c3 quagga: Security Advisory - quagga - CVE-2013-2236
Stack-based buffer overflow in the new_msg_lsa_change_notify function in
the OSPFD API (ospf_api.c) in Quagga before 0.99.22.2, when
--enable-opaque-lsa and the -a command line option are used, allows
remote attackers to cause a denial of service (crash) via a large LSA.

http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2013-2236

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-08-05 16:23:58 -04:00
Robert Yang c587fa5546 meta-networking: fix no newline at end of file
Add a '\n' to the last line of the file to fix:

No newline at end of file

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-07-15 14:57:27 +02:00
Yue Tao 26b31ad728 quagga: Security Advisory - CVE-2012-1820
The bgp_capability_orf function in bgpd in Quagga 0.99.20.1 and earlier
allows remote attackers to cause a denial of service (assertion failure
and daemon exit) by leveraging a BGP peering relationship and sending a
malformed Outbound Route Filtering (ORF) capability TLV in an OPEN
message.

http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-1820

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2014-06-15 23:21:56 -04:00
Changhyeok Bae 04dcd55c9d quagga, fim, gpsd, hddtemp, libunwind, lzip: Change the url to variable for savannah in SRC_URI
* The variables (SAVANNAH_MIRROR)
  are defined in oe-core/meta/conf/bitbake.conf.
* MIRRORS in quagga and libunwind is removed.
  because the MIRRORS of savannah is globally defined
  in oe-core/meta/classes/mirrors.bbclass

Signed-off-by: Changhyeok Bae <changhyeok.bae@lge.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-05-15 12:30:17 +02:00
Kai Kang 715893e5ff quagga: fix CVE-2013-6051
Backport patch to fix CVE-2013-6051.

Signed-off-by: Hu <yadi.hu@windriver.com>
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-04-24 21:07:46 -04:00
Kai Kang a277f303df quagga: fix QA warning
When build quagga, it shows QA warnings:

WARNING: QA Issue: ELF binary '/home/build/poky/build/tmp/work/i586-poky-linux/quagga/0.99.21-r2.0/packages-split/quagga-bgpd/usr/sbin/bgpd' has relocations in .text
WARNING: QA Issue: ELF binary '/home/build/poky/build/tmp/work/i586-poky-linux/quagga/0.99.21-r2.0/packages-split/quagga-ripngd/usr/sbin/ripngd' has relocations in .text

The configure script tests compiler whether support option '-fPIE'. If
support, it pass option '-fPIE' to compiler then cause these QA
warnings.

Disable configure script to check option '-fPIC'.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-04-24 21:07:46 -04:00
Changhyeok Bae 3fb3c2c8f8 quagga: Add mirror site
* The SRC_URI is not accessible.
  So need to add mirror site referred by the original site.
* The problem is that
  http://download.savannah.nongnu.org/releases redirects to closest mirror
  and few mirrors (e.g. .jp) weren't working correctly while
  http://download-mirror.savannah.gnu.org/releases/ seems to be reliable.

Signed-off-by: Changhyeok Bae <changhyeok.bae@lge.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-04-24 20:39:15 -04:00
Robert Yang c1d420a3b6 quagga: work with new readline
The Function and CPPFunction had been removed by in readline 6.3, use
the new functions to replace them.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2014-03-27 15:41:12 -04:00
Roy Li 7a673eb37e quagga: close the stdout/stderr as in other daemons
Once babald becomes a background daemon, it should not output information to
stdout, so need to close stdout.

In fact, other daemons close their stdout when they run into background, like
ospfd, isisd and bgpd, by calling daemon() which is in lib/daemon.c

Closing the stdout can fix a tee hang issue { #/usr/sbin/babeld -d |tee tmp }

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-02-23 23:17:29 +01:00
Roy Li 7cb2f9e4c2 quagga: fix a typOS
it should be CPP, not cpp; this typOS makes vtysh unable to work.

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-02-12 20:09:26 -05:00
Roy Li 75c52163b0 quagga: Backport a patch to fix extract.pl for cross compilation
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-27 15:20:06 -05:00
Hongxu Jia ec152778cd quagga: add pam support for vtysh
According to DISTRO_FEATURES to add pam support for quagga, and import
configure file from Fedora.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 11:14:31 -05:00
Bopeng Liu 98367f46aa quagga: Fix watchquagga initscript problem.
Change the default config file for making watchquagga can startup successful

Signed-off-by: Bopeng Liu <Bopeng.Liu@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 11:01:47 -05:00
Xufeng Zhang 936febdff7 quagga: Avoid duplicate connected address adding to the list
commit 27ba970b9("quagga/ripd: Fix two bugs after received SIGHUP signal")
introduces an regression: ifp->connected list is cleaned up when ripd is
restarting, however, for interface addresses which are not specified in
ripd configuration file, they are never to be added into ifp->connected
again, this will lead to some abnormal behavior for route advertising.

Instead of cleaning up the ifp->connected list to avoid duplicated
connected address being added into this list, we can check this
condition during interface address adding process and return early
when an identical address has already been added.

Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 10:53:17 -05:00
Robert Yang b613318e14 quagga: use /bin/false as the login shell
Use /bin/false as the login shell, just like what Ubuntu does,
otherwise there might be secure issue.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 09:53:53 -05:00
Roy Li e854d0d71e quagga: backport a patch from 0.99.22 to fix "no ip address" command
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-06 15:10:58 -05:00
Chen Qi 7f1b4775ef quagga: fix pkg_postinst
This patch mainly involves two changes.
1. Create necessary files at do_install task. Add these configuration
   files to the CONFFILES variable.
2. Move the `chmod' and `chown' commands to do_install task.

After these two changes, qugga can run successfully at rootfs time.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-10-31 13:00:48 -04:00
Xufeng Zhang 27ba970b9e quagga/ripd: Fix two bugs after received SIGHUP signal
There are two problems for ripd implementation after received
SIGHUP signal:
1). ripd didn't clean up ifp->connected list before reload
    configuration file which makes the same advertise packet
    being sent multiple times(depends on how many SIGHUP was recieved).
2). ripd reset ri->split_horizon flag to RIP_NO_SPLIT_HORIZON
    during restart which is different from the flag when ripd is
    firstly started up, leading to unnecessary route to be advertised.

[YOCTO #5266]

Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-10-31 10:05:00 -04:00
Chen Qi 08c4c25787 quagga: fix babeld_option
Fix babeld_option to make babeld start correctly.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-09-23 09:56:56 -04:00
Joe MacDonald c896a9bbdc quagga: fix info-related QA warning
Correct the warning:

   quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped in a particular package.

Simply remove the installed 'dir' file if info docs are installed.

Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-09-05 17:05:53 -04:00
Roy.Li d4571b3d94 quagga: two fixes
1. quagga should depend on iproute2, since ip from busybox is not sufficient
2. fix a typOS(should chmod, not chown)

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-08-16 11:00:19 -04:00
Joe MacDonald 5c3e27684c quagga: backport documentation patch
The latest stable quagga adopted this patch:

   http://git.savannah.gnu.org/gitweb/?p=quagga.git;a=commit;h=b58c90807c9d0bfa9601704c7490a16070906004

to repair a documentation build error.  Trivial backport.

Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-08-12 09:00:00 -04:00
Martin Jansa 676a28cb6b quagga: add PACKAGECONFIG for capabilities
* it's autodetected from sysroot
* add PACKAGECONFIG to make it deterministic

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2013-07-30 11:17:11 +02:00
Aws Ismail af74e53e97 Quagga: sync zebra routing table with the kernel one
When interface goes down, and there are some static routes that are
made with ip route, they are going to be deleted from kernel fib.
That's what kernel does by default. But they are not going to be
deleted from zebra's fib. They will be declared inactive.

This issue was originally discussed in [1] and a patch was proposed.

[1] http://www.gossamer-threads.com/lists/quagga/dev/22609

Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2013-05-07 10:23:41 -04:00
Martin Jansa a45830a39b recipes: Unify indentation
* This change is only aesthetic (unlike indentation in Python
  tasks).
* Some recipes were using tabs.
* Some were using 8 spaces.
* Some were using mix or different number of spaces.
* Make them consistently use 4 spaces everywhere.
* Yocto styleguide advises to use tabs (but the only reason to keep
  tabs is the need to update a lot of recipes). Lately this advice
  was also merged into the styleguide on the OE wiki.
* Using 4 spaces in both types of tasks is better because it's less
  error prone when someone is not sure if e.g.
  do_generate_toolchain_file() is Python or shell task and also allows
  to highlight every tab used in .bb, .inc, .bbappend, .bbclass as
  potentially bad (shouldn't be used for indenting of multiline
  variable assignments and cannot be used for Python tasks).
* Don't indent closing quote on multiline variables
  we're quite inconsistent wheater it's first character on line
  under opening quote or under first non-whitespace character in
  previous line.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
2013-04-15 16:23:17 +02:00
Aws Ismail 525306f575 Quagga: clean up whitespaces/hardtabs in recipe
Minor clean-up for some places where whitespaces
and hardtabs stil existed.

Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2013-03-25 13:09:38 -04:00
Aws Ismail f64db3011c Quagga has no snmp support, unrecognized options --enable-tcp-md5
1. Quagga's tcp-md5 has been renamed to linux24-tcp-md5

2. net-snmp needs to have mib-modules=smux enabled to enable
quagga to support snmp. Make the net-snmp option dependent
on the DISTRO_FEATURE snmp.

3. Misc: install the sample conf files for quagga. Also,
Make sure that the post install script is being run
on the target rather than during the rootfs creation
stage.

Signed-off-by: Amy Fong <amy.fong@windriver.com>
Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2013-03-25 13:09:34 -04:00
Paul Eggleton e762ce3fc0 quagga: add from OE-Classic, update and tidy-up
* Update to 0.99.21
* Fix SRC_URI to point to a working download location
* Make LICENSE more accurate
* Add LIC_FILES_CHKSUM
* Add old gentoo patch to fix libcap linking errors
* Put binaries in sbindir
* Use useradd.bbclass to create user/groups
* Handle hardcoded paths in initscript
* Add LSB headers to initscript (borrowed from debian)
* Tidy up packaging and directory references
* Add SUMMARY

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
2012-11-27 14:43:58 -05:00