* This change is only aesthetic (unlike indentation in Python
tasks).
* Some recipes were using tabs.
* Some were using 8 spaces.
* Some were using mix or different number of spaces.
* Make them consistently use 4 spaces everywhere.
* Yocto styleguide advises to use tabs (but the only reason to keep
tabs is the need to update a lot of recipes). Lately this advice
was also merged into the styleguide on the OE wiki.
* Using 4 spaces in both types of tasks is better because it's less
error prone when someone is not sure if e.g.
do_generate_toolchain_file() is Python or shell task and also allows
to highlight every tab used in .bb, .inc, .bbappend, .bbclass as
potentially bad (shouldn't be used for indenting of multiline
variable assignments and cannot be used for Python tasks).
* Don't indent closing quote on multiline variables
we're quite inconsistent wheater it's first character on line
under opening quote or under first non-whitespace character in
previous line.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
From: Mark Hatle <mark.hatle@windriver.com>
I was helping someone with building netperf from meta-networking last
night, and stumbled on what I think is a bug.
SUMMARY = "A networking benchmarking tool"
DESCRIPTION = "Network performance benchmark including tests for TCP,
UDP, sockets, ATM and more."
SECTION = "console/network"
HOMEPAGE = "http://www.netperf.org/"
LICENSE = "netperf"
LICENSE_FLAGS = "commercial"
In the above, the LICENSE_FLAGS are set to 'commercial'. I think this
is incorrect. It should be set to 'non-commercial'.
There is a subtle difference between them which is why I think it's a
bug...
commercial -- there are some commercial requirements necessary to use
this recipe in a commercial device... you are responsible for
understanding them and doing whatever is necessary... (for
non-commercial devices you can likely use it...)
non-commercial -- this item is restricted to non-commercial users only.
As in the case of netperf, the license says it's only for
non-commercial use.
So anyway, my suggestion is to simply change the value of the flag.
Reported-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
Martin Jansa
Joe MacDonald
xin.ouyang@windriver.com