101 Commits

Author SHA1 Message Date
Joe Slater 711c97a079 openconnect: PACKAGECONFIG certain dependencies
Some items now in DEPENDS are configuration options,
so we create PACKAGECONFIG[] entries for them.

We do not select pcsc-lite by default because it is
GPLv3.

Signed-off-by: Joe Slater <jslater@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
(cherry picked from commit a27d4a75c5)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2016-08-16 10:29:41 -07:00
Ioan-Adrian Ratiu 6812a4a40a openconnect: add missing dependencies
They were autodetected and triggered QA warnings

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2016-05-09 19:05:02 -07:00
Ioan-Adrian Ratiu 3c76d0a568 vpnc: stage vpnc-script
The vpn connection handling script is used during building openconnect
so we need to stage it.

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2016-05-02 14:03:00 -07:00
Ioan-Adrian Ratiu 51717e1187 openconnect: add recipe
openconnect is a FOSS VPN client designed to work with Cisco AnyConnect
and Pulse Connect Secure (Juniper SSL).

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2016-05-02 14:03:00 -07:00
Mark Asselstine cb87e40af9 samba: remove dependency on ctdb
During rootfs creation the following error is being hit

  Preparing...         ######################################## [  0%]
  warning: Removing ctdb-2.5.1-r0@core2_64 due to file /usr/bin/ctdb
  conflicting with samba-4.4.2-r0@core2_64
  error: ctdb-dev-2.5.1-r0 conflicts with ctdb = 2.5.1-r0

Looking at the relationship between samba and ctdb it appears that the
landscape has changed some starting in version 4.2. Samba now includes
and installs ctdb instead of relying on stand-alone ctdb. Referencing
https://wiki.samba.org/index.php/CTDB_Setup we see this activated by
'--with-cluster-support' which we do pass to configure based on the
bb.

Dropping the DEPENDS on ctdb resolves this issue.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-05-02 12:25:38 -04:00
Richard Leitner d73f12b8f6 samba: fix paths in sysv initscript
The sysv initscript provided by samba assumes smbd and nmbd are
installed in /opt/samba/bin/. In our case both binaries are installed to
/usr/sbin/ by default. Therefore fix these paths.

Furthermore fix the log and config directory as well as the name of the
initscript in its usage text.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-29 11:57:48 -04:00
Armin Kuster d5baf7825b samba: fix QA warnings.
V2:
Fix
WARN: samba: samba rdepends on libarchive, but it isn't a build dependency?

V1:
WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]

Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-29 11:57:48 -04:00
Johannes Pointner d7c6dc86ac samba: add volatile file to support readonly rootfs
This patch adds a volatile file for samba which was removed by the
update from 3.6.25 to 4.1.12. This file is necessary to build a image
that uses the read-only-rootfs feature.

Signed-off-by: Johannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-29 11:57:47 -04:00
Joe MacDonald 825cf152cc samba: Update to latest stable
The previous version of Samba had many critical security updates that
would've required significant backporting effort.  Update to the latest
stable release instead.

Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-29 11:57:47 -04:00
Pascal Bach 6a31e7c139 dhcpcd: cleanup recipe
- use autotools-brokensep instead of B = "${S}"
- make udev configurable via PACKAGECONFIG
- make ipv6 configurable via PACKAGECONFIG

Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Signed-off-by: Freudiger Raphael <raphael.freudiger@siemens.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-01 12:05:27 -04:00
Pascal Bach 259f5cd6f3 dhcpcd: update to version 6.10.1
Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-01 12:05:27 -04:00
lchristina26 441c328ec4 wolfssl: update to version 3.9.0
Update includes new leantls configuration, RSA OAEP padding support,
Arduino example client, and more.

Signed-off-by: lchristina26 <leah@wolfssl.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-01 12:05:27 -04:00
mike.looijmans@topic.nl b1883d2cdc samba: Fix typo in PACKAGECONFIG for "acl" and "aio"
There's a "-" too many in PACKAGECONFIG[acl] and PACKAGECONFIG[aio]
resulting in errors like this if built without acl:
  waf: error: no such option: ---without-acl-support

Remove the extra "-" to fix the issue.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-29 16:23:35 -05:00
Kai Kang 038a0031a4 samba: update systemd service files
Update systemd service files of samba. There are no '@BASE_BINDIR@' and
'@SBINDIR@' in these service files, so drop the original replacement.
Command kill is installed to /bin/kill, then correct in the service files.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-29 16:23:34 -05:00
Richard Purdie e5ac52b4ad inetutils: Fix build when static libs disabled
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-29 16:23:34 -05:00
Joe MacDonald cce08ed6f7 samba: Fix build when static libs disabled
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22 19:49:46 -05:00
Mike Crowe daca3e8cb9 vlan: Explicitly set EXTRA_OEMAKE as required
This recipe currently relies on EXTRA_OEMAKE having been to set to
"-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make
this explicit so that the default in bitbake.conf can be changed.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22 15:51:19 -05:00
Mike Crowe 3bccfa713f vpnc: Explicitly set EXTRA_OEMAKE as required
This recipe currently relies on EXTRA_OEMAKE having been to set to
"-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make
this explicit so that the default in bitbake.conf can be changed.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22 15:51:19 -05:00
Martin Jansa 80e00f95f7 snort: Blacklist
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22 15:51:18 -05:00
Stephano Cetola 3c2c8491ed fix missing packageconfig for samba with sysvinit
Building samba with sysvinit currently throws a QA warning about
"invalid PACKAGECONFIG: sysv". This fixes that issue.

Signed-off-by: Stephano Cetola <stephanoc@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22 15:49:40 -05:00
Nate Karstens 1a864b4842 dhcpcd: add recipe for dhcpcd
Adds a new recipe for dhcpcd version 6.10.0.

Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-26 18:08:17 -05:00
mike.looijmans@topic.nl 751659c243 recipes-connectivity/samba: Only rmdir directories that exist
Depending on PACKAGECONFIG selection, the /run/samba directory may not
have been created. Make the do_install_append handle both situations
by checking whether these directories exist before attempting to remove
them.

This fixes do_install failing with an error like this:
 rmdir: failed to remove '/.../samba/4.1.12-r0/image/run/samba': No such file or directory

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-20 21:41:46 -05:00
Jackie Huang d43819eb04 samba: backport patches for cross-compiling
* Adds a new mode for samba cross-compiling:

  When both --cross-answers and --cross-execute are set, this means:
  - Use cross-answers
  - If answer is unknown, then instead of adding UNKNOWN to the cross-answers
    file and failing configure, the new mode runs cross-execute to determine the
    answer and adds that to the cross-answers file.

* And some fixes and improvements for cross-compiling.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-20 21:41:42 -05:00
Jackie Huang 51c35fca0f samba: fix the incorrect tmpfiles installed directory
- The tmpfiles are always installed in /usr/lib
  even for multilib.
- It makes no sense to have two tmpfiles in both
  /usr/lib/tmpfiles.d and /etc/tmpfiles.d, install
  it as one in /etc/tmpfiles.d.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-20 21:41:42 -05:00
Jens Rehsack b03c856798 samba: move RDEPENDS of perl from samba to samba-pidl
samba-pidl is the package containing the perl-extension, so RDEPENDS
must include perl for samba-pidl, not for samba.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-05 12:43:34 -05:00
Jens Rehsack 4095ac2dea samba: split packages similar to samba3
Since entire samba4 package is around 25MB, trying to save some space by
splitting the package into several ones logically grouped as they were
at samba3 in fido.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-05 12:43:34 -05:00
Wenzong Fan 71cebad979 samba: add PACKAGECONFIG for valgrind
* Add configure options '--without-valgrind'
* Disable valgrind by default since it doesn't build for all targets

This fixes build errors:

  ../source3/include/includes.h:156:31: fatal error: \
    valgrind/memcheck.h: No such file or directory
  compilation terminated.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-05 12:43:32 -05:00
Jens Rehsack 6b17037edf samba: make cyrus-sasl optional
Since waf doesn't allow override check results via environment, a patch
is needed to remove the bad check when an optional feature is unwanted.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04 12:58:10 -05:00
Jens Rehsack 9546714d24 samba: fix typo distinguishing between plain sysv init and lsb init
During fix for distinguishing between lsb flavoured sysv init and pure, on the
rocks version, author introduced a typo.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04 12:58:10 -05:00
Jens Rehsack 0db903b44c talloc: rename to libtalloc and cleanup dependency mess
To avoid errors when building dev-images (talloc-dev is missing), and to avoid
insane empty packages for that, rename talloc -> libtalloc as libtevent shows.

With that, remove dependencies to attr/xattr - unless explicitely enabled via
PACKAGECONFIG.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04 12:58:10 -05:00
Roy Li 3132c6ef09 ufw: improve RRECOMMENDS
ufw needs lots of netfilter module to run

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-30 13:20:29 -05:00
Zhiquan Li 49fa307d47 snort: 2.9.6.0 -> 2.9.7.5
Upgrade snort from 2.9.6.0 to 2.9.7.5, as its dependency upgrade daq from
2.0.2 to 2.0.6, and accordingly update the patches:

* Add 2 new patches for snort to solve the cross compile issues
* Discard 2 snort patches since it is not needed
* Refresh the patch for daq new version
* Remove redundant '/' to getting round the rpm debugedit bug:
  canonicalization unexpectedly shrank character

Signed-off-by: Zhiquan Li <zhiquan.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-30 13:00:15 -05:00
Martin Jansa c8ee819e34 samba: add dependency on libbsd cyrus-sasl and PACKAGECONFIG for dmapi
* dmapi is in meta-filesystems
* hopefully fixes:
  WARN: samba: samba rdepends on cyrus-sasl, but it isn't a build dependency?
  WARN: samba: samba rdepends on dmapi, but it isn't a build dependency?
  WARN: samba: samba rdepends on libbsd, but it isn't a build dependency?
  WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
  WARN: samba: samba-python rdepends on libbsd, but it isn't a build dependency?

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-11-16 21:50:11 +01:00
Martin Jansa 0e525daafe samba, ctdb, libldb, libtdb, libtevent, talloc: move to meta-networking
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-11-16 21:50:10 +01:00
Martin Jansa 6d7a4d6a81 snort: fix indentation
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-11-11 10:47:20 +01:00
Zhiquan Li f08b9e8e7d snort: fix m4 causes out of memory during configure
There is an incorrect m4_define() in configure.in which will result in an
infinite recursion, and it doesn't make sense, since snort 2.9.7 it has been
commented out. We follow this solution to fix it.

Signed-off-by: Zhiquan Li <zhiquan.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-11-11 10:47:20 +01:00
Martin Jansa 29e99a67da vpnc, arptables, lirc, debootstrap, log4cpp, python-ldap: drop unused variable PRIORITY
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-10-23 12:53:22 +02:00
Ioan-Adrian Ratiu 6233934a50 meta-networking: recipes-connectivity: add relayd recipe
relayd is a daemon to relay and dynamically redirect incoming
connections to a target host.

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-10-21 15:59:03 -04:00
Qi.Chen@windriver.com 395519075d inetutils: fix rcp to work with large file
This issue occurs When we copy file by rcp command between target and host,
if the file > 2GB, it will fail.
The cause is that it used incorrect data type on file size in sink() of rcp.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-10-21 12:13:03 -04:00
Kai Kang 43188cd974 inetutils: add package config pam
Add package config pam for inetutils. And only check pam_appl.h when pam
is enabled.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-09-14 10:40:35 -04:00
Jagadeesh Krishnanjanappa 7e1de2f5c3 lftp: add new recipe
LFTP is a sophisticated file transfer program with command line interface.
It supports FTP, HTTP, FISH, SFTP, HTTPS and FTPS protocols.
Every operation in lftp is reliable, that is any non-fatal error is handled and
the operation is retried automatically. So if downloading breaks, it will be
restarted from the point automatically.

Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-09-11 10:39:09 -04:00
Kai Kang 55713b8c15 inetutils: 1.9.2 -> 1.9.4
Upgrade inetutils from 1.9.2 to 1.9.4.

* add homepage
* update inetutils/version.patch

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>

Conflicts:
	meta-networking/recipes-connectivity/inetutils/inetutils/telnetd-Fix-deadlock-on-cleanup.patch
2015-08-19 20:43:30 -04:00
Li xin 6aa74f9fca crda: upgrade 3.13 -> 3.18
Dropped backported patches(commit-id):
-crda-Add-DESTDIR-support-in-install-libreg-rules-in-.patch(2cabb258)
-crda-Fix-the-linking-order-to-avoid-compilation-erro.patch(fefefdb2)

Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-08-06 11:01:39 -04:00
Roy Li c12b9596af inetutils: fix tcpd path in xinetd configuration file
tcpd from tcp-wrapper is installed into /usr/sbin/, not /usr/bin/
using sed to dynamical update the path to add the robust

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-16 13:27:02 -04:00
Li Wang 279b7cd97d inetutils: move daemon servers from bin to sbin directory
move daemon servers from bin to sbin directory:
tftpd, telnetd, rshd, rexecd and rlogind

Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-15 15:23:27 -04:00
Joe Slater 8621b51850 drbd ufw linux-atm: correct certain packaging error
The named packages explicitly install some items under /lib,
but the recipes assume they are in base_libdir.  We change
the recipes.

Signed-off-by: Joe Slater <jslater@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-06 15:27:52 -04:00
Roy Li 01ffc1f2b2 mbedtls: upgrade to 1.3.10
1. PolarSSL is now rebranded as mbed TLS.
2. upgrade to include CVE-2015-1182 fix:
   http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-1182

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-06-05 22:18:30 -04:00
Joe MacDonald 8980f0d2a2 meta-networking: standardize SECTION values
SECTION has been used inconsistently throughout the recipes in this layer.
Convert them to all use the same convention.

Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-06-05 20:42:25 -04:00
Armin Kuster 0850d63009 daq: move recipe to meta-networking
ERROR: Nothing PROVIDES 'libdnet' (but /home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/daq/daq_2.0.2.bb DEPENDS on or otherwise requires it). Close matches:
 libnet
 libnewt
 libidn
ERROR: Required build target 'daq' has no buildable providers.
Missing or unbuildable dependency chain was: ['daq', 'libdnet']

world build fails for meta-oe.

move daq to meta-networking where snort and libdnet both reside.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
2015-05-11 11:01:35 +02:00
Andreas Oberritter ac4e327ee7 vpnc: don't rdepend on kernel-module-tun
Kernel modules may be built-in, so rrecommend it instead.

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-04-15 21:52:47 -04:00