The 4.20251130.1 upgrade switched SRC_URI from a git snapshot to the
GitHub release tarball. That tarball ships a prebuilt libxdo.pc but does
not include pc.sh, even though the Makefile still carries the rule:
libxdo.pc: VERSION
sh pc.sh $(VERSION) $(INSTALLLIB) $(INSTALLINCLUDE) > libxdo.pc
do_install runs "make install", which pulls in the installpc target.
Because libxdo.pc depends on VERSION, whenever a fresh unpack leaves
VERSION with an mtime newer than or equal to libxdo.pc, make considers
the shipped libxdo.pc stale and re-runs pc.sh, failing with:
sh: 0: cannot open pc.sh: No such file
make: *** [Makefile:153: libxdo.pc] Error 2
The mtime ordering after unpack is not deterministic, so the failure is
intermittent and typically shows up after a re-fetch. On top of that,
the prebuilt libxdo.pc in the tarball hard-codes /usr/local paths, so
even when the race does not trigger, an incorrect .pc gets installed.
Ship the upstream pc.sh alongside the recipe and place it in ${S} so the
installpc rule regenerates libxdo.pc with the correct libdir/includedir
from EXTRA_OEMAKE. This fixes both the build failure and the wrong paths.
Signed-off-by: Yogesh Tyagi <yogesh.tyagi@intel.com>
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
The upstream Makefile invokes ldconfig at install time, which runs the
host ldconfig against the target sysroot (${D}) and is both unnecessary
and non-deterministic for cross builds. Pass LDCONFIG=true to make the
install step a no-op for ldconfig, matching the WITHOUT_RPATH_FIX
handling already used here.
Signed-off-by: Yogesh Tyagi <yogesh.tyagi@intel.com>
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
Changelog:
============
- Fix bug in typing/keyboard causing xdotool to send extra modifier
keys in certain cases. When xkeyboard-config 2.46 is installed,
xdotool would send incorrect key sequences for function keys, for
example incorrectly sending "Alt + F3" when F3 was requested.
- Add 'windowlower' command
- Fix some crashes in xdo_get_desktop_for_window
- Fix mouse movement under Xwayland when multiple screens are present
- mousemove --sync no only waits if the cursor is expected to actually move
- Remove dependency on libXi that was leftover from Wayland detection code no
longer used in xdotool
- Bump SONAME to 4 hopefully to resolve ABI issues with previous versions of libxdo.
- Code improvements intended to reduce compiler warnings
- Add support for Cygwin when building
- Test suite works again!
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* as shown in the log.do_compile:
cc1: warning: include location "/usr/local/include" is unsafe for cross-compilation [-Wpoison-system-directories]
* it's caused by Makefile doing:
DEFAULT_LIBS=-L/usr/X11R6/lib -L/usr/local/lib -lX11 -lXtst
DEFAULT_INC=-I/usr/X11R6/include -I/usr/local/include
LIBS=$(shell pkg-config --libs x11 xtst 2> /dev/null || echo "$(DEFAULT_LIBS)")
INC=$(shell pkg-config --cflags x11 xtst 2> /dev/null || echo "$(DEFAULT_INC)")
which always uses the DEFAULT_* since RSS, because there was no
pkg-config in the recipe sysroot
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
When MACHINE=qemux86-64 and enable multilib:
ERROR: QA Issue: xdotool: Files/directories were installed but not shipped in any package:
/usr/lib
/usr/lib/libxdo.so
/usr/lib/libxdo.so.1
/usr/lib/.debug
/usr/lib/.debug/libxdo.so.1
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]
Pass the correct libdir to make, otherwise it assumes $prefix/lib even
on multilib.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Changes:
- rename SUMMARY with length > 80 to DESCRIPTION
- rename DESCRIPTION with length < 80 to (non present tag) SUMMARY
- drop final point character at the end of SUMMARY string
- remove trailing whitespace of SUMMARY line
Note: don't bump PR
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* This change is only aesthetic (unlike indentation in Python
tasks).
* Some recipes were using tabs.
* Some were using 8 spaces.
* Some were using mix or different number of spaces.
* Make them consistently use 4 spaces everywhere.
* Yocto styleguide advises to use tabs (but the only reason to keep
tabs is the need to update a lot of recipes). Lately this advice
was also merged into the styleguide on the OE wiki.
* Using 4 spaces in both types of tasks is better because it's less
error prone when someone is not sure if e.g.
do_generate_toolchain_file() is Python or shell task and also allows
to highlight every tab used in .bb, .inc, .bbappend, .bbclass as
potentially bad (shouldn't be used for indenting of multiline
variable assignments and cannot be used for Python tasks).
* Don't indent closing quote on multiline variables
we're quite inconsistent wheater it's first character on line
under opening quote or under first non-whitespace character in
previous line.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
* fixes:
xdotool-1.20100416.2809: xdotool: Files/directories were installed but not shipped
/usr/man
/usr/man/man1
/usr/man/man1/xdotool.1
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Yogesh Tyagi
Wang Mingyu
Richard Purdie
Khem Raj
Faiz HAMMOUCHE
Denys Dmytriyenko
Martin Jansa
Yi Zhao
Matthieu CRAPET
Koen Kooi