do_compile failed building the userspace mount helper:
mount.vboxsf.c:38:10: fatal error: errno.h: No such file or directory
vbsfmount.c:36:10: fatal error: assert.h: No such file or directory
The kernel modules build fine; only the userspace utility fails. This
recipe inherits module, and module.bbclass sets INHIBIT_DEFAULT_DEPS=1
(kernel modules build -nostdinc and do not need libc). That suppresses
BASE_DEFAULT_DEPS (virtual/cross-cc virtual/compilerlibs virtual/libc)
and only re-adds virtual/cross-cc + virtual/cross-binutils, so the
target libc headers and crt objects are never staged into
recipe-sysroot. But this recipe also compiles an ordinary hosted
userspace program (utils/mount.vboxsf), which needs libc.
Add back virtual/compilerlibs and virtual/libc. Using the same
virtual/* provider names OE lists in BASE_DEFAULT_DEPS keeps this
correct across libc (glibc/musl) and toolchain (gcc/clang) choices.
Verified errno.h is staged and mount.vboxsf compiles, links and is
packaged into ${base_sbindir}.
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
This is a maintenance release. The following items were fixed or added:
GUI: Fixed VirtualBox VM Manager crash when host was resuming from sleep (github:gh-121, github:gh-170)
GUI: Updated native language support for Traditional Chinese, Greek, Swedish, Hungarian and Indonesian translations
NAT: Fixed issue when multiple port forwarding rules affected NAT functionality (github:gh-232)
Linux host and guest: Introduced initial support for kernel 6.18
Linux Guest Additions: Introduced additional fixes for RHEL 9.6 and 9.7 kernels (github:GH-12)
Windows Guest Additions: Introduced additional fixes for issue when installation was failing in Windows XP SP2 guest (github:GH-142)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Bruce Ashfield <bruce.ashfield@gmail.com>
Please see
https://git.yoctoproject.org/poky/commit/?id=4dd321f8b83afecd962393101b2a6861275b5265
for what changes are needed, and sed commands that can be used to make them en masse.
I've verified that bitbake -c patch world works with these, but did not run a world
build; the majority of recipes shouldn't need further fixups, but if there are
some that still fall out, they can be fixed in followups.
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Recipes are much more readable with whitespace around the assignment operators.
Fix various assignments in meta-openembedded recipes to show this is definitely
the preferred formatting.
This fixes recipes with larger numbers of issues but there are just under 100
other references left to fix.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This update fixes the build against kernel 6.12+
Also, to fix the following warning:
WARNING: vboxguestdrivers-7.0.22-r0 do_unpack: vboxguestdrivers: the directory ${WORKDIR}/${BP}
(build/tmp/work/qemux86_64-poky-linux/vboxguestdrivers/7.0.22/vboxguestdrivers-7.0.22) pointed
to by the S variable doesn't exist - please set S within the recip
We can set S for the unpack task, much the same way we do for
patch. Alternate solutions should work (do_unpack[dirs], etc), but
they didn't work in my testing.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Replace references of WORKDIR with UNPACKDIR where it makes sense to do
so in preparation for changing the default value of UNPACKDIR.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
When building against the 6.5 kernel (and kernel headers), the following
build error is encountered:
| vboxguestdrivers/7.0.10/vboxguestdrivers-7.0.10/vboxvideo/vbox_fb.c:194:24: error: 'drm_fb_helper_sys_fillrect' undeclared here (not in a function); did you mean 'drm_fb_helper_lastclose'?
| 194 | .fb_fillrect = drm_fb_helper_sys_fillrect,
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~
| | drm_fb_helper_lastclose
| vboxguestdrivers/7.0.10/vboxguestdrivers-7.0.10/vboxvideo/vbox_fb.c:195:24: error: 'drm_fb_helper_sys_copyarea' undeclared here (not in a function); did you mean 'drm_fb_helper_set_par'?
| 195 | .fb_copyarea = drm_fb_helper_sys_copyarea,
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~
| | drm_fb_helper_set_par
| vboxguestdrivers/7.0.10/vboxguestdrivers-7.0.10/vboxvideo/vbox_fb.c:196:25: error: 'drm_fb_helper_sys_imageblit' undeclared here (not in a function) | 196 | .fb_imageblit = drm_fb_helper_sys_imageblit,
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
A patch from vbox-dev has been posted to fix the issue.
Upstream-Status: Submitted [https://www.mail-archive.com/vbox-dev@virtualbox.org/msg10129.html]
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The vboxguest drivers (vboxsf) fail to build against the 6.4 kernel
due to iovec iterator changes.
This is a port of the gentoo patches (which are picked from the upstream
virtualbox repository) to address the compilation issues.
We obviously can drop these when the next version of the guest additions
is available.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
When fixing the build against 5.19, we added a copy of stdarg.h out of
the kernel source. That of course works fine if the kernel-source has
already been staged, but is an error otherwise.
We add the explicit dependency to the export_source task, to make sure
that the source files are present. We already have a DEPENDS on virutal/kernel
in the recipe, so we just tweak when the source will be in place.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
We've bounced back and forth with the mixed libc/kernel module structure of
these drivers. In particular the location and content of stdarg.h has caused
compile problems, or can't be located.
In particular kernel versions have issues with stdarg.h and compatibility
with the sysroot and libc-headers/uapi. If we include the file directly from
the kernel source (STAGING_KERNEL_DIR) we get conflicting types on many
structures, due to kernel .h files being found before libc .h files. if we
grab just this one file from the source, and put it into our file structure,
everything holds together.
Plus, we get to drop a patch we are carrying to change the include of
stdarg.h
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
In kernel v5.15+ stdarg.h is part of the kernel source, and the
upstream project has a change to prefer that stdarg.h to the
c-library variant and hence includes it as <linux/stdarg.h>, which
leads to the following build error:
| In file included from ../vboxsf/include/iprt/types.h:34,
| from ../vboxsf/include/iprt/string.h:33,
| from mount.vboxsf.c:53:
| ../vboxsf/include/iprt/stdarg.h:49:13: fatal error: linux/stdarg.h: No such file or directory
| 49 | # include <linux/stdarg.h>
| | ^~~~~~~~~~~~~~~~
If we modify our build of the vboxdrivers to have the kernel source
directory on the include path (to find linux/stdarg.h, that leads
to the following errors:
In file included from build/tmp/work/qemux86_64-poky-linux/vboxguestdrivers/6.1.28-r0/recipe-sysroot/usr/include/stdlib.h:394,
| from mount.vboxsf.c:36:
| build/tmp/work/qemux86_64-poky-linux/vboxguestdrivers/6.1.28-r0/recipe-sysroot/usr/include/sys/types.h:192:20: note: previous declaration of 'blkcnt_t' with type 'blkcnt_t' {aka 'long int'}
| 192 | typedef __blkcnt_t blkcnt_t; /* Type to count number of disk blocks. */
| | ^~~~~~~~
| In file included from build/tmp/work-shared/qemux86-64/kernel-source/include/linux/time.h:5,
| from poky/build/tmp/work-shared/qemux86-64/kernel-source/include/linux/stat.h:19,
| from build/tmp/work/qemux86_64-poky-linux/vboxguestdrivers/6.1.28-r0/recipe-sysroot/usr/include/bits/statx.h:31,
Our libc-headers are safe and don't lead to the potential conflicing
information that the upstream commit is guarding against. The easiest
solution is to revert the upstream change and trust our headers.
Upstream-Status: Inappropriate [OE specific]
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
the utsrelease.h is not included in the STAGING_KERNEL_DIR, but in STAGING_KERNEL_BUILDDIR
So, adding a hacky symlink into the source directory fixes the issue for now.
This can be re-evaluated if poky maintainers start shipping such file into another directory or patch module*.bbclass to take account
of this additional dir into *FLAGS
https://errors.yoctoproject.org/Errors/Details/613563/
make: Entering directory 'TOPDIR/build/tmp/work/qemux86-yoe-linux/vboxguestdrivers/6.1.28-r0/vboxguestdrivers-6.1.28/utils'
i686-yoe-linux-gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=TOPDIR/build/tmp/work/qemux86-yoe-linux/vboxguestdrivers/6.1.28-r0/recipe-sysroot -I. -I../vboxsf -I../vboxsf/include -DRT_OS_LINUX -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DVBOX -DVBOX_WITH_HGCM -DIN_MODULE -DIN_GUEST_R0 -c -o mount.vboxsf.o mount.vboxsf.c
i686-yoe-linux-gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=TOPDIR/build/tmp/work/qemux86-yoe-linux/vboxguestdrivers/6.1.28-r0/recipe-sysroot -I. -I../vboxsf -I../vboxsf/include -DRT_OS_LINUX -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DVBOX -DVBOX_WITH_HGCM -DIN_MODULE -DIN_GUEST_R0 -c -o vbsfmount.o vbsfmount.c
In file included from ../vboxsf/include/iprt/stdarg.h:47,
from ../vboxsf/include/iprt/types.h:34,
from ../vboxsf/include/iprt/string.h:33,
from mount.vboxsf.c:53:
../vboxsf/include/iprt/linux/version.h:40:11: fatal error: generated/utsrelease.h: No such file or directory
40 | # include <generated/utsrelease.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:39: recipe for target 'mount.vboxsf.o' failed
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The bump of the reference / default kernels and libc-headers to 5.14
in oe-core broke the build of the vbox guest drivers.
The upstream SVN already has 5.14 fixes for the issues, so these are
SVN exports of the changes. When a new release is available, we can
drop the changes.
Also in this patch, is a fixup for the source directory for patching.
It was broken in the overrides conversion, and since there weren't
any active patches at the time, we didn't notice that source wasn't
set to a directory where quilt could actually find the files.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This is the result of automated script (0.9.1) conversion:
oe-core/scripts/contrib/convert-overrides.py .
converting the metadata to use ":" as the override character instead of "_".
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
This function has been added upstream as well, therefore the patch is no
longer needed
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Gianfranco Costamagna <locutusofborg@debian.org>
Khem Raj
Gianfranco Costamagna
Khem Raj
Weisser, Pascal
Alexander Kanavin
Richard Purdie
Bruce Ashfield
Gianfranco Costamagna
Mingli Yu
Gianfranco Costamagna
Martin Jansa