Commit Graph

72 Commits

Author SHA1 Message Date
Sanjay Chitroda d4277b4734 netkit-telnet: Fix CVE-2022-39028
References:
https://nvd.nist.gov/vuln/detail/CVE-2022-39028
https://security-tracker.debian.org/tracker/CVE-2022-39028

Upstream Patch:
https://cgit.freebsd.org/src/commit/?id=6914ffef4e23

- Patch is adopted from FreeBSD, as same vulnerability of
  telnetd is applicable to FreeBSD and netkit-telnet packages.

Signed-off-by: Sanjay Chitroda <sanjay.chitroda@einfochips.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit d629fe71e4)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2023-09-27 07:40:56 -04:00
Khem Raj 076e5413ad netkit-ftp: Update to debian patch 34
drop md5 SRC_URI checksums while here

Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 29c80a7350)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2023-05-07 12:30:14 -04:00
Martin Jansa 285b7cd79f .patch: fix Upstream-Status formatting issues reported by patchreview tool from oe-core
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2023-02-24 08:45:44 -08:00
Yi Zhao ac0da5190f meta-networking: fix Upstream-Status format
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2023-02-24 08:45:44 -08:00
Martin Jansa ea63f13846 .patch: fix Signed-off-by formatting issues reported by patchreview tool from oe-core
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2023-01-27 17:06:52 -08:00
Martin Jansa e99f187966 .patch: fix Upstream-Status formatting issues reported by patchreview tool from oe-core
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2023-01-27 17:06:52 -08:00
Khem Raj 095e86660f netkit-telnet: Drop using register storage class keyword
Its dropped since c++17 and modern compilers have started to error on
its use

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2023-01-16 21:23:07 -08:00
Khem Raj 536281a175 netkit-telnet: Add time.h from strftime/time prototypes
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-09-07 16:44:54 -07:00
Khem Raj 1d4b29aa87 recipes: Use renamed SKIP_RECIPE varFlag
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-02-21 18:12:04 -08:00
Martin Jansa c61dc077bb Convert to new override syntax
This is the result of automated script (0.9.1) conversion:

oe-core/scripts/contrib/convert-overrides.py .

converting the metadata to use ":" as the override character instead of "_".

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2021-08-03 10:21:25 -07:00
Mingli Yu f555f9d34f netkit-telnet: Update SRC_URI
Fix the below do_fetch warning:
WARNING: netkit-telnet-0.17-r0 do_fetch: Failed to fetch URL http://ftp.linux.org.uk/pub/linux/Networking/netkit/netkit-telnet-0.17.tar.gz, attempting MIRRORS if available

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-03-11 00:12:55 -08:00
Martin Jansa e48aabf951 netkit-rsh: inherit update-alternatives
* fixes:
  netkit-rsh-0.17-r0 do_package_qa: QA Issue: netkit-rsh: recipe defines ALTERNATIVE_netkit-rsh-client but doesn't inherit update-alternatives. This might fail during do_rootfs later! [missing-update-alternatives]
  netkit-rsh-0.17-r0 do_package_qa: QA Issue: netkit-rsh: recipe defines ALTERNATIVE_netkit-rsh-server but doesn't inherit update-alternatives. This might fail during do_rootfs later! [missing-update-alternatives]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-09-18 06:07:50 -07:00
Khem Raj 43bd735121 netkit-rwho: Convert to ontarget postinst
Starting the service is something to be done when its booted on target

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-09-01 15:37:44 -07:00
Khem Raj 6cfa5d0ed8 netkit-ftp: Use update-alternatives for ftp
So it can live with other providers

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-09-01 15:37:44 -07:00
Khem Raj 915844297a netkit-rwho: Use update-alternatives for tftp
So it can live along other providers

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-09-01 15:37:44 -07:00
Khem Raj ab2f8b5051 netkit-rpc: Use update alternatives for rpcinfo
This helps it live along rpcbind

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-09-01 15:37:44 -07:00
Julius Hemanth Pitti 232b82afd4 netkit-telnetd: Fix buffer overflow in netoprintf
netoprintf() was not handling a case where
return value of vsnprintf is greater than
"size"(2nd argument), results in buffer overflow
while adjusting "nfrontp" pointer to point
beyond "netobuf" buffer.

Here is one such case where "nfrontp"
crossed boundaries of "netobuf", and
pointing to another global variable.

(gdb) p &netobuf[8255]
$5 = 0x55c93afe8b1f <netobuf+8255> ""
(gdb) p nfrontp
$6 = 0x55c93afe8c20 <terminaltype> "\377"
(gdb) p &terminaltype
$7 = (char **) 0x55c93afe8c20 <terminaltype>
(gdb)

This resulted in crash of telnetd service
with segmentation fault.

Signed-off-by: Julius Hemanth Pitti <jpitti@cisco.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-07-21 16:46:36 -07:00
Konrad Weihmann 4cca3eff38 netkit-rsh: properly append PACKAGECONFIG
As ??= assignment will be overwritten by += in any case,
one can't define a default of PACKAGECONFIG in this recipe.
Using _append instead mitigates chances of accidental overwriting
the default

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-06-03 15:15:43 -07:00
Robert P. J. Day d7f5367b53 use weak assignments for PNBLACKLIST in recipe files
Make sure PNBLACKLIST assignments in recipe files use weak assignment,
so they can be overridden in, for example, local.conf files.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-05-26 10:28:39 -07:00
Yi Zhao 9bfc740863 netkit-telnet: fix CVE-2020-10188
Reference:
https://nvd.nist.gov/vuln/detail/CVE-2020-10188

Patch from Fedora:
https://src.fedoraproject.org/rpms/telnet/raw/master/f/telnet-0.17-overflow-exploit.patch

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-04-25 08:32:42 -07:00
Ovidiu Panait ffc0878a7c netkit-telnet: Use alternatives to avoid manpage conflict
Fix the following manpage installation conflict:
 * check_data_file_clashes: Package netkit-telnet-doc wants to install file /usr/share/man/man8/telnetd.8
   But that file is already provided by package  * inetutils-doc

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-03-31 23:56:42 -07:00
Khem Raj 4d01b009bb netkit-rwho: Add logic to apply patches from tarball
This recipe fetches from debian archives, therefore we need logic to
apply the patches which are part of tarball

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-03-29 17:32:21 -07:00
Jeremy Puhlman aba9beee85 netkit-ftp: clean in configure step broken
| DEBUG: Executing shell function autotools_preconfigure
| NOTE: make clean
| (cd  ftp && make clean)
| make[1]: Entering directory '/project/tmp/work/i586-oe-linux/netkit-ftp/0.17-r0/netkit-ftp-0.17/ftp'
| Makefile:3: ../MCONFIG: No such file or directory
| make[1]: *** No rule to make target '../MCONFIG'.  Stop.

Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-02-27 17:24:19 -08:00
Khem Raj 7f454d0af8 netkit-rwho: Include stdint.h for int32_t
This ensures that when libc does not include stdint.h indirectly then it
still can compile

Fixes
| ../include/protocols/rwhod.h:57:2: error: unknown type name 'int32_t'; did you mean 'uint32_t'?

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-11-06 06:32:14 -08:00
Christophe PRIOUZEAU 19b5d0ce66 netkit-telnet: Clarify BSD license variant
The License of netkit-telnet is BSD-4-Clause.

Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-24 01:01:43 -07:00
Christophe PRIOUZEAU 00dd3fba33 netkit-rwho: Clarify BSD license variant
The License of netkit-rwho is BSD-4-Clause.

Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-24 01:01:43 -07:00
Christophe PRIOUZEAU bf652f46b7 netkit-rusers: Clarify BSD license variant
The License of netkit-rusers is BSD-3-Clause.

Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-24 01:01:43 -07:00
Christophe PRIOUZEAU b1442dba90 netkit-ftp: Clarify BSD license variant
The License of netkit-ftp is BSD-4-Clause.

Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-24 01:01:43 -07:00
Khem Raj eca729d98e drbd,netkit-rusers: Blacklist packages
These fail to build always

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-09-07 12:35:54 -07:00
Adrian Bunk 8ebe4041dd Replace EXCLUDE_FROM_WORLD_libc-musl = "1" with COMPATIBLE_HOST_libc-musl = 'null'
This gives users a proper error message when trying to build
a known non-building package.

netkit-rsh already had COMPATIBLE_HOST_libc-musl = 'null'.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-29 09:06:54 -07:00
Khem Raj 28ae6b2cea netkit-rusers: Fix cross-build after glibc dropped rpc
Remove runtime checks from configure script which wont run correctly

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-12 09:11:01 -07:00
Khem Raj 017bf0cfaf netkit-rusers: Depend on rpcsvc-proto-native for rpcgen tool
Fixes
| rup.c:51:10: fatal error: 'rstat.h' file not found
| #include "rstat.h"
|          ^~~~~~~~~
| 1 error generated.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-08-08 10:04:23 -07:00
Khem Raj 119cfb25d4 netkit-rusers: Add dep on rpcsvc-proto for rpc headers
needs rpcsvc/rstat.h which is no longer in libc but provided
by separate package now

Fixes
up.c:51:10: fatal error: rstat.h: No such file or directory
   51 | #include "rstat.h"
      |          ^~~~~~~~~
compilation terminated.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-07-30 19:15:24 -07:00
Changqing Li 1ac44de135 netkit-telnet: add rconflicts
fix below error:

file /etc/xinetd.d/telnet conflicts between attempted installs of netkit-telnet-0.17-r0.i586 and inetutils-telnetd-1.9.4-r0.i586
file /usr/sbin/in.telnetd conflicts between attempted installs of netkit-telnet-0.17-r0.i586 and inetutils-telnetd-1.9.4-r0.i586

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-05-29 02:21:42 -07:00
Qi.Chen@windriver.com 772f7d8703 netkit-rsh: add tag to CVE patch
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-05-07 09:33:49 -07:00
Yi Zhao b701de37b4 netkit-rsh: security fixes
Fix CVE-2019-7282, CVE-2019-7283

References:
https://nvd.nist.gov/vuln/detail/CVE-2019-7282
https://nvd.nist.gov/vuln/detail/CVE-2019-7283

Patch from:
https://sources.debian.org/src/netkit-rsh/0.17-20/debian/patches/fix-CVE-2018-20685-and-CVE-2019-6111.patch

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-04-16 21:07:25 -07:00
Tom Rini 059aa8962e netkit-rsh: don't build under musl
Uses iruserok and ruserok which are GNU extensions available in glibc
but not in musl

Cc: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-03-14 07:24:03 -07:00
Kai Kang bcbbace221 netkit-telnet: fix qa warnings of alternative target
When build lib32-netkit-telnet that multilib is enabled, it shows qa
warnings of alternative target:

| WARNING: lib32-netkit-telnet-0.17-r0 do_package: netkit-telnet:
|   alternative target (/usr/bin/telnet or /usr/bin/telnet.netkit-telnet)
|   does not exist, skipping...
| WARNING: lib32-netkit-telnet-0.17-r0 do_package: netkit-telnet: NOT
|   adding alternative provide /usr/bin/telnet:
|   /usr/bin/telnet.netkit-telnet does not exist
| WARNING: lib32-netkit-telnet-0.17-r0 do_package: netkit-telnet: alt_link
|   == alt_target: /usr/bin/telnet == /usr/bin/telnet

Set ALTERNATIVE_TARGET to fix the issue.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-02 10:05:06 -07:00
Changqing Li 32e5f35069 netkit-telnet: update SRC_URI
update SRC_URI since previous is not valid now

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-01 10:04:54 -07:00
Khem Raj 7e0fa293b7 recipes: Exclude non-buildable recipes from world for musl build
These recipes need to be fixed for musl, until they are needed
on musl lets remove them from world builds

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-08-20 23:58:58 -07:00
Martin Jansa 0627becf6b netkit-rsh: fix build with glibc-2.28
* fixes:
  rexecd.c:79:10: fatal error: crypt.h: No such file or directory
  ...
  ld: error: cannot find -lcrypt

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-08-16 21:41:15 -04:00
Jeremy Puhlman 877934f93e netkit-telnet: Switch to update-alternatives
Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-06-14 20:25:16 -07:00
Seiichi Ishitsuka d9e257abbe telnetd: Fix deadlock on cleanup
The cleanup function in telnetd is called both directly and on SIGCHLD signals.
This triggered a deadlock in glibc and was reproduced in glibc 2.27 while
running on a 4.14.30 kernel.

Signed-off-by: Seiichi Ishitsuka <ishitsuka.sc@ncos.nec.co.jp>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-06-12 09:13:46 -07:00
Yi Zhao f6d550cc6b netkit-telnet: add UPSTREAM_CHECK_URI
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-29 12:57:23 -07:00
Khem Raj f1230ec9b1 netkit-rusers: Fix build when libc does not have nis builtin
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-17 08:32:26 -07:00
Khem Raj e60ce61024 recipes: Link with libtirpc
glibc no longer provides rpc implementation

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-17 08:32:26 -07:00
Mingli Yu 5205419c22 netkit-rsh: correct the file attribute
Correct the file /etc/pam.d/rsh attribute

Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
Signed-off-by: Dengke Du <dengke.du@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2017-10-11 16:22:50 -04:00
Huang Qiyu 96034e9844 netkit-telnet: Add HOMEPAGE info into recipe file.
Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2017-09-22 14:37:18 -04:00
Khem Raj 58db2c981b netkit-rpc: Link libtirpc on musl
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2017-09-12 10:55:08 -04:00
Khem Raj 0ede604e78 netkit-tftp: Fix build with musl
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2017-09-12 10:55:07 -04:00