There is a bug in uutils-coreutils causing stdbuf to include the HOST version of libstdbuf.so, even when cross-compiled.
As a side-effect, the uutils-coreutils binary was containing the buildpath, because RPATH was set on libstdbuf.so.
Thus the buildpath error can be re-enabled.
This is tracked upstream by https://github.com/uutils/coreutils/issues/6591
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Co-authored-by: Gyorgy Sarvari <skandigraun@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* don't seem to be needed, I don't see any failures or changes after removing them
* they were needed before in older version as explained by Etienne in:
https://lists.openembedded.org/g/openembedded-devel/message/115756
regarding SELINUX_INCLUDE_DIR, it was definitely needed as I implemented the recipe. During implementation I submitted this patch to selinux-sys ( https://github.com/koutheir/selinux-sys/commit/a6667c404ecc33266f66e9516bb8e30150c41ec2 ) to correctly use this variable, and was getting a build error without this fix because the rust crate selinux-sys was not finding the selinux header-file (specifically, the bindgen tool).
However, this was in 2022, and since then there has been this patch in selinux-sys: https://github.com/koutheir/selinux-sys/commit/d3ea4674e18c5240918348bea4ec6248e50516e5 , and it seems that the variable is not needed any more.
At least I'm not able to reproduce the build error which I was getting, even with commenting out SELINUX_LIB_DIR and SELINUX_INCLUDE_DIR.
The header-file is used for generating rust code from the C header-file using bindgen, so I don't think it makes a difference whether the native version or the target version is used.
This is the old build error I was getting:
process didn't exit successfully: `/workdir/build/tmp-glibc/work/armv8a-linux/uutils-coreutils/0.0.14.AUTOINC+43a5b8c7d7-r0/build/target/release/build/selinux-sys-0849198bc1fef4a4/build-script-build` (exit status: 101)
--- stdout
cargo:root=/workdir/build/tmp-glibc/work/armv8a-linux/uutils-coreutils/0.0.14.AUTOINC+43a5b8c7d7-r0/build/target/aarch64-snap-linux/release/build/selinux-sys-d96748d49908959f/out
cargo:rerun-if-env-changed=SELINUX_STATIC_aarch64-snap-linux
cargo:rerun-if-env-changed=SELINUX_STATIC_aarch64_snap_linux
cargo:rerun-if-env-changed=TARGET_SELINUX_STATIC
| --- stderr
| src/selinux-sys.h:1:10: fatal error: 'selinux/selinux.h' file not found
| src/selinux-sys.h:1:10: fatal error: 'selinux/selinux.h' file not found, err: true
Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* use STAGING_LIBDIR_NATIVE variable for LIBCLANG_PATH and SELINUX_LIB_DIR
and STAGING_INCDIR_NATIVE variable for SELINUX_INCLUDE_DIR
not sure why it uses native version and not target, but at least use
correct variable
* hardcoding:
${WORKDIR}/recipe-sysroot-native${libdir}
is just wrong when there is a better variable
* This path won't be correct for multilib builds where target ${libdir}
might be e.g. /usr/lib32 while native libdir is /usr/lib.
* even with meta-selinux added to my builds I don't see any failure
maybe these variables aren't really used?
* use STAGING_LIBDIR_NATIVE variable which uses correct ${libdir_native}
OE qemuarm64-multilib@ /OE/build/oe-core $ bitbake-getvar LIBCLANG_PATH -r uutils-coreutils
#
# $LIBCLANG_PATH [2 operations]
# exported /OE/build/oe-core/meta-openembedded/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.0.29.bb:33
# [export] "1"
# set /OE/build/oe-core/meta-openembedded/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.0.29.bb:33
# "${WORKDIR}/recipe-sysroot-native${libdir}"
# pre-expansion value:
# "${WORKDIR}/recipe-sysroot-native${libdir}"
export LIBCLANG_PATH="/OE/build/oe-core/tmp/work/cortexa57-oe-linux/uutils-coreutils/0.0.29/recipe-sysroot-native/usr/lib64"
OE qemuarm64-multilib@ /OE/build/oe-core $ bitbake-getvar STAGING_LIBDIR_NATIVE -r uutils-coreutils
#
# $STAGING_LIBDIR_NATIVE
# set /OE/build/oe-core/openembedded-core/meta/conf/bitbake.conf:425
# "${STAGING_DIR_NATIVE}${libdir_native}"
STAGING_LIBDIR_NATIVE="/OE/build/oe-core/tmp/work/cortexa57-oe-linux/uutils-coreutils/0.0.29/recipe-sysroot-native/usr/lib"
OE qemuarm64-multilib@ /OE/build/oe-core $ bitbake-getvar LIBCLANG_PATH -r lib32-uutils-coreutils
#
# $LIBCLANG_PATH [2 operations]
# exported /OE/build/oe-core/meta-openembedded/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.0.29.bb:33
# [export] "1"
# set /OE/build/oe-core/meta-openembedded/meta-oe/recipes-core/uutils-coreutils/uutils-coreutils_0.0.29.bb:33
# "${WORKDIR}/recipe-sysroot-native${libdir}"
# pre-expansion value:
# "${WORKDIR}/recipe-sysroot-native${libdir}"
export LIBCLANG_PATH="/OE/build/oe-core/tmp/work/armv7at2-neon-oemllib32-linux-gnueabi/lib32-uutils-coreutils/0.0.29/recipe-sysroot-native/usr/lib32"
OE qemuarm64-multilib@ /OE/build/oe-core $ bitbake-getvar STAGING_LIBDIR_NATIVE -r lib32-uutils-coreutils
#
# $STAGING_LIBDIR_NATIVE
# set /OE/build/oe-core/openembedded-core/meta/conf/bitbake.conf:425
# "${STAGING_DIR_NATIVE}${libdir_native}"
STAGING_LIBDIR_NATIVE="/OE/build/oe-core/tmp/work/armv7at2-neon-oemllib32-linux-gnueabi/lib32-uutils-coreutils/0.0.29/recipe-sysroot-native/usr/lib"
Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The usage of nobranch=1 in SRC_URI allows using unprotected branches.
This change updates the real branch name in place of nobranch=1 for these components.
Signed-off-by: Sourav Kumar Pramanik <pramanik.souravkumar@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Note: the removal of "name=XXX" in the crates.inc file is normal
and due to a change in cargo-update-recipe-crates.bbclass in poky.
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
musl is not supported because the libc crate does not support functions like "endutxent" at the moment,
so src/uucore/src/lib/features.rs disables utmpx when targetting musl.
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This comment does not make sense any more, now that the auto-generated
recipe has been removed.
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Commit 93d691d58c did not add the crates checksum (even though the commit message
says it did), and the crates fetcher is now failing with "No checksum
specified".
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
uutils-coreutils is a rewrite of GNU coreutils in Rust.
It is licensed under MIT license.
To use this recipe add this line to your distro configuration:
PREFERRED_PROVIDER_coreutils = "uutils-coreutils"
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Etienne Cordonnier
Richard Purdie
Martin Jansa
Wang Mingyu
alperak
Sourav Kumar Pramanik
Frederic Martinsons
Etienne Cordonnier