From 33393507ba8209f0d6b85b391c525b4c70807275 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Mon, 3 Jul 2023 12:33:16 +0000 Subject: [PATCH] Correct function signatures Fixes builds on mips where clang reports an error ../deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h:661:5: error: no matching member function for call to 'Move' Move(tmp, src, type.value_type()); ^~~~ Upstream-Status: Submitted [https://chromium-review.googlesource.com/c/v8/v8/+/3235674] Signed-off-by: Archana Polampalli --- deps/v8/src/wasm/baseline/liftoff-assembler.h | 6 +++--- .../src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h | 2 +- .../src/wasm/baseline/riscv/liftoff-assembler-riscv64-inl.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/deps/v8/src/wasm/baseline/liftoff-assembler.h b/deps/v8/src/wasm/baseline/liftoff-assembler.h index 7cb2f500..713d16db 100644 --- a/deps/v8/src/wasm/baseline/liftoff-assembler.h +++ b/deps/v8/src/wasm/baseline/liftoff-assembler.h @@ -681,7 +681,7 @@ class LiftoffAssembler : public MacroAssembler { void FinishCall(const ValueKindSig*, compiler::CallDescriptor*); // Move {src} into {dst}. {src} and {dst} must be different. - void Move(LiftoffRegister dst, LiftoffRegister src, ValueKind); + void Move(LiftoffRegister dst, LiftoffRegister src, ValueKind kind); // Parallel register move: For a list of tuples , move the // {src} register of kind {kind} into {dst}. If {src} equals {dst}, ignore @@ -851,8 +851,8 @@ class LiftoffAssembler : public MacroAssembler { inline void MoveStackValue(uint32_t dst_offset, uint32_t src_offset, ValueKind); - inline void Move(Register dst, Register src, ValueKind); - inline void Move(DoubleRegister dst, DoubleRegister src, ValueKind); + inline void Move(Register dst, Register src, ValueKind kind); + inline void Move(DoubleRegister dst, DoubleRegister src, ValueKind kind); inline void Spill(int offset, LiftoffRegister, ValueKind); inline void Spill(int offset, WasmValue); diff --git a/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h b/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h index bd59f162..56b4d70c 100644 --- a/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h +++ b/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64-inl.h @@ -672,7 +672,7 @@ void LiftoffAssembler::Store(Register dst_addr, Register offset_reg, pinned.set(dst_op.rm()); LiftoffRegister tmp = kScratchReg2; // Save original value. - Move(tmp, src, type.value_type()); + Move(tmp, src, type.value_type().kind()); src = tmp; pinned.set(tmp); diff --git a/deps/v8/src/wasm/baseline/riscv/liftoff-assembler-riscv64-inl.h b/deps/v8/src/wasm/baseline/riscv/liftoff-assembler-riscv64-inl.h index a3c94af0..456e5334 100644 --- a/deps/v8/src/wasm/baseline/riscv/liftoff-assembler-riscv64-inl.h +++ b/deps/v8/src/wasm/baseline/riscv/liftoff-assembler-riscv64-inl.h @@ -452,7 +452,7 @@ void LiftoffAssembler::Store(Register dst_addr, Register offset_reg, pinned.set(dst_op.rm()); LiftoffRegister tmp = GetUnusedRegister(src.reg_class(), pinned); // Save original value. - Move(tmp, src, type.value_type()); + Move(tmp, src, type.value_type().kind()); src = tmp; pinned.set(tmp);