mirror of
https://github.com/openembedded/meta-openembedded.git
synced 2026-09-26 00:11:04 +00:00
Alex Kiernan
3daef71e73
do_install ran make with -e, which gives the environment precedence over the makefile's own assignments. Every CPPFLAGS and CFLAGS use in the makefile is +=, seeded from the environment, so -e discarded all of the makefile's additions: the CPPFLAGS += defining PACKAGE, PACKAGE_BUGREPORT and VERSION, the conditional -DNLS, -pipe and $(WARNINGS). utils/info.c and utils/set.c then failed to build with "'PACKAGE' undeclared" while relinking cpufreq-info and cpufreq-set, which install: pulls in via all:. Dropping -e also makes do_install and do_compile agree on flags, where the install-time relink previously produced binaries built differently from the ones do_compile had made. -e predates 0001-dont-unset-cflags.patch, back when the makefile assigned CC/LD/AR/STRIP/RANLIB absolutely and -e was the only way to override them. That patch is dropped here in favour of setting CC on the make command line, which outranks a makefile assignment without needing a patch at all. CC is the only one of those variables the makefile ever references: LD, AR and RANLIB are assigned but never used, and STRIP only feeds STRIPCMD, which the recipe already overrides. The patch had carried Upstream-Status: Pending since 2012 against a project whose last commit was in 2011. NLS becomes a PACKAGECONFIG rather than an inline USE_NLS expression so it can be set per-recipe, defaulting from USE_NLS so existing behaviour is unchanged. gettext-native is named explicitly because gettext.bbclass substitutes gettext-minimal-native when USE_NLS is no, and that has no xgettext/msgmerge for the update-gmo target this enables. The gettext inherit becomes conditional on the same PACKAGECONFIG, deferred because it reads a value that does not exist yet at that point in the parse. AI-Generated: Claude Opus 5 (Claude Code) Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>