From 0a7274e934d6252d63e17a8b718ca4095035ebec Mon Sep 17 00:00:00 2001 From: Doug Goldstein Date: Thu, 29 Dec 2016 11:44:02 -0600 Subject: [PATCH] add section on merging PRs --- Home.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Home.md b/Home.md index 991cabf..bad19cb 100644 --- a/Home.md +++ b/Home.md @@ -12,4 +12,9 @@ There are then 6 additional tags that can be applied to an issue: * `bug` - an issue with something in the repo * `meta` - relates to project management * `help wanted` - anyone knowledgable in this area is requested to assist -* `patches welcome` - none of the maintainers are actively looking to fix this and the community is encouraged to provide a patch \ No newline at end of file +* `patches welcome` - none of the maintainers are actively looking to fix this and the community is encouraged to provide a patch + +### Merging PRs + +A PR must run through CI and pass successfully. If the change is something that would not be run by the existing CI loop then there should be some notes on how the change was verified to be correct. Consideration should be made to whether the existing CI loop should be enhanced to test this use case to ensure it does not regress. A PR must have an approved review by another maintainer and can be merged in by another maintainer. If two maintainers approve the PR then you are welcome to merge your own PR in. +