mirror of
https://git.yoctoproject.org/meta-ti
synced 2026-07-21 03:17:18 +00:00
Koen Kooi
62 lines
1.9 KiB
Diff
62 lines
1.9 KiB
Diff
From b0f40f6545e9ae32b6cbd2cb03561de805297bf5 Mon Sep 17 00:00:00 2001
|
|
From: Nishanth Menon <nm@ti.com>
|
|
Date: Thu, 26 May 2011 19:39:19 -0700
|
|
Subject: [PATCH 14/19] OMAP2+: cpufreq: put clk if cpu_init failed
|
|
|
|
Release the mpu_clk in fail paths.
|
|
|
|
Reported-by: Todd Poynor <toddpoynor@google.com>
|
|
Signed-off-by: Nishanth Menon <nm@ti.com>
|
|
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
|
|
---
|
|
arch/arm/mach-omap2/omap2plus-cpufreq.c | 14 +++++++++++---
|
|
1 files changed, 11 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
|
|
index 3af7cda..e019297 100644
|
|
--- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
|
|
+++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
|
|
@@ -162,8 +162,10 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
|
|
if (IS_ERR(mpu_clk))
|
|
return PTR_ERR(mpu_clk);
|
|
|
|
- if (policy->cpu >= NR_CPUS)
|
|
- return -EINVAL;
|
|
+ if (policy->cpu >= NR_CPUS) {
|
|
+ result = -EINVAL;
|
|
+ goto fail_ck;
|
|
+ }
|
|
|
|
policy->cur = policy->min = policy->max = omap_getspeed(policy->cpu);
|
|
result = opp_init_cpufreq_table(mpu_dev, &freq_table);
|
|
@@ -171,12 +173,14 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
|
|
if (result) {
|
|
dev_err(mpu_dev, "%s: cpu%d: failed creating freq table[%d]\n",
|
|
__func__, policy->cpu, result);
|
|
- return result;
|
|
+ goto fail_ck;
|
|
}
|
|
|
|
result = cpufreq_frequency_table_cpuinfo(policy, freq_table);
|
|
if (!result)
|
|
cpufreq_frequency_table_get_attr(freq_table, policy->cpu);
|
|
+ else
|
|
+ goto fail_ck;
|
|
|
|
policy->min = policy->cpuinfo.min_freq;
|
|
policy->max = policy->cpuinfo.max_freq;
|
|
@@ -199,6 +203,10 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
|
|
policy->cpuinfo.transition_latency = 300 * 1000;
|
|
|
|
return 0;
|
|
+
|
|
+fail_ck:
|
|
+ clk_put(mpu_clk);
|
|
+ return result;
|
|
}
|
|
|
|
static int omap_cpu_exit(struct cpufreq_policy *policy)
|
|
--
|
|
1.7.2.5
|
|
|