mirror of
https://git.yoctoproject.org/poky
synced 2026-05-08 17:19:20 +00:00
xwayland: Fix CVE-2025-26594
The patches are copied from xserver-xorg recipe. CVE reported for both and patches apply on both. Upstream-Commit: https://gitlab.freedesktop.org/xorg/xserver/-/commit/01642f26 & https://gitlab.freedesktop.org/xorg/xserver/-/commit/b0a09ba6 (From OE-Core rev: 2d8bf72c892a3a6422e2a294fb6528ff67971e6d) Signed-off-by: Vijay Anusuri <vanusuri@mvista.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
This commit is contained in:
committed by
Steve Sakoman
parent
0f565d1c27
commit
3cc6f0bb5c
@@ -0,0 +1,54 @@
|
|||||||
|
From 01642f263f12becf803b19be4db95a4a83f94acc Mon Sep 17 00:00:00 2001
|
||||||
|
From: Olivier Fourdan <ofourdan@redhat.com>
|
||||||
|
Date: Wed, 27 Nov 2024 11:27:05 +0100
|
||||||
|
Subject: [PATCH] Cursor: Refuse to free the root cursor
|
||||||
|
|
||||||
|
If a cursor reference count drops to 0, the cursor is freed.
|
||||||
|
|
||||||
|
The root cursor however is referenced with a specific global variable,
|
||||||
|
and when the root cursor is freed, the global variable may still point
|
||||||
|
to freed memory.
|
||||||
|
|
||||||
|
Make sure to prevent the rootCursor from being explicitly freed by a
|
||||||
|
client.
|
||||||
|
|
||||||
|
CVE-2025-26594, ZDI-CAN-25544
|
||||||
|
|
||||||
|
This vulnerability was discovered by:
|
||||||
|
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative
|
||||||
|
|
||||||
|
v2: Explicitly forbid XFreeCursor() on the root cursor (Peter Hutterer
|
||||||
|
<peter.hutterer@who-t.net>)
|
||||||
|
v3: Return BadCursor instead of BadValue (Michel Danzer
|
||||||
|
<michel@daenzer.net>)
|
||||||
|
|
||||||
|
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
|
||||||
|
Suggested-by: Peter Hutterer <peter.hutterer@who-t.net>
|
||||||
|
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
||||||
|
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1828>
|
||||||
|
|
||||||
|
Upstream-Status: Backport [https://gitlab.freedesktop.org/xorg/xserver/-/commit/01642f26]
|
||||||
|
CVE: CVE-2025-26594
|
||||||
|
Signed-off-by: Vijay Anusuri <vanusuri@mvista.com>
|
||||||
|
---
|
||||||
|
dix/dispatch.c | 4 ++++
|
||||||
|
1 file changed, 4 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/dix/dispatch.c b/dix/dispatch.c
|
||||||
|
index 4602961..30b95c1 100644
|
||||||
|
--- a/dix/dispatch.c
|
||||||
|
+++ b/dix/dispatch.c
|
||||||
|
@@ -3107,6 +3107,10 @@ ProcFreeCursor(ClientPtr client)
|
||||||
|
rc = dixLookupResourceByType((void **) &pCursor, stuff->id, RT_CURSOR,
|
||||||
|
client, DixDestroyAccess);
|
||||||
|
if (rc == Success) {
|
||||||
|
+ if (pCursor == rootCursor) {
|
||||||
|
+ client->errorValue = stuff->id;
|
||||||
|
+ return BadCursor;
|
||||||
|
+ }
|
||||||
|
FreeResource(stuff->id, RT_NONE);
|
||||||
|
return Success;
|
||||||
|
}
|
||||||
|
--
|
||||||
|
2.25.1
|
||||||
|
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
From b0a09ba6020147961acc62d9c73d807b4cccd9f7 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Hutterer <peter.hutterer@who-t.net>
|
||||||
|
Date: Wed, 4 Dec 2024 15:49:43 +1000
|
||||||
|
Subject: [PATCH] dix: keep a ref to the rootCursor
|
||||||
|
|
||||||
|
CreateCursor returns a cursor with refcount 1 - that refcount is used by
|
||||||
|
the resource system, any caller needs to call RefCursor to get their own
|
||||||
|
reference. That happens correctly for normal cursors but for our
|
||||||
|
rootCursor we keep a variable to the cursor despite not having a ref for
|
||||||
|
ourselves.
|
||||||
|
|
||||||
|
Fix this by reffing/unreffing the rootCursor to ensure our pointer is
|
||||||
|
valid.
|
||||||
|
|
||||||
|
Related to CVE-2025-26594, ZDI-CAN-25544
|
||||||
|
|
||||||
|
Reviewed-by: Olivier Fourdan <ofourdan@redhat.com>
|
||||||
|
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1828>
|
||||||
|
|
||||||
|
Upstream-Status: Backport [https://gitlab.freedesktop.org/xorg/xserver/-/commit/b0a09ba6]
|
||||||
|
CVE: CVE-2025-26594
|
||||||
|
Signed-off-by: Vijay Anusuri <vanusuri@mvista.com>
|
||||||
|
---
|
||||||
|
dix/main.c | 4 ++++
|
||||||
|
1 file changed, 4 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/dix/main.c b/dix/main.c
|
||||||
|
index bfc8add..38e29ce 100644
|
||||||
|
--- a/dix/main.c
|
||||||
|
+++ b/dix/main.c
|
||||||
|
@@ -231,6 +231,8 @@ dix_main(int argc, char *argv[], char *envp[])
|
||||||
|
FatalError("could not open default cursor font");
|
||||||
|
}
|
||||||
|
|
||||||
|
+ rootCursor = RefCursor(rootCursor);
|
||||||
|
+
|
||||||
|
#ifdef PANORAMIX
|
||||||
|
/*
|
||||||
|
* Consolidate window and colourmap information for each screen
|
||||||
|
@@ -271,6 +273,8 @@ dix_main(int argc, char *argv[], char *envp[])
|
||||||
|
|
||||||
|
Dispatch();
|
||||||
|
|
||||||
|
+ UnrefCursor(rootCursor);
|
||||||
|
+
|
||||||
|
UndisplayDevices();
|
||||||
|
DisableAllDevices();
|
||||||
|
|
||||||
|
--
|
||||||
|
2.25.1
|
||||||
|
|
||||||
@@ -29,6 +29,8 @@ SRC_URI = "https://www.x.org/archive/individual/xserver/xwayland-${PV}.tar.xz \
|
|||||||
file://CVE-2024-31083-0001.patch \
|
file://CVE-2024-31083-0001.patch \
|
||||||
file://CVE-2024-31083-0002.patch \
|
file://CVE-2024-31083-0002.patch \
|
||||||
file://CVE-2024-9632.patch \
|
file://CVE-2024-9632.patch \
|
||||||
|
file://CVE-2025-26594-1.patch \
|
||||||
|
file://CVE-2025-26594-2.patch \
|
||||||
"
|
"
|
||||||
SRC_URI[sha256sum] = "d11eeee73290b88ea8da42a7d9350dedfaba856ce4ae44e58c045ad9ecaa2f73"
|
SRC_URI[sha256sum] = "d11eeee73290b88ea8da42a7d9350dedfaba856ce4ae44e58c045ad9ecaa2f73"
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user