From 44f2059a93f1af2e749b26705ec90b47b1cea45d Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 28 Feb 2025 10:09:56 +0000 Subject: [PATCH] shadow-native: Disable syslog usage Spamming the build host's syslog with useradd information during image creation isn't great. Add a patch to disable that. It may be possible to convince upstream to make it a configure option but for now the patch is trivial and reduces host impact to the logs. (From OE-Core rev: a52572886e60e4aff9d54b57bf45a301e1dec1ee) Signed-off-by: Richard Purdie --- .../shadow/files/disable_syslog.patch | 22 +++++++++++++++++++ meta/recipes-extended/shadow/shadow_4.17.2.bb | 1 + 2 files changed, 23 insertions(+) create mode 100644 meta/recipes-extended/shadow/files/disable_syslog.patch diff --git a/meta/recipes-extended/shadow/files/disable_syslog.patch b/meta/recipes-extended/shadow/files/disable_syslog.patch new file mode 100644 index 0000000000..7299a8e61c --- /dev/null +++ b/meta/recipes-extended/shadow/files/disable_syslog.patch @@ -0,0 +1,22 @@ +When building images using shadow-native, we shouldn't be spamming the host's +log with lots of syslog messages which aren't relavent. Disable syslog use +in the native case. + +Upstream-Status: Inappropriate [Would upstream accept a configure option?] +Signed-off-by: Richard Purdie + +Index: shadow-4.17.2/lib/defines.h +=================================================================== +--- shadow-4.17.2.orig/lib/defines.h ++++ shadow-4.17.2/lib/defines.h +@@ -88,7 +88,9 @@ + + /* cleaner than lots of #ifdefs everywhere - use this as follows: + SYSLOG((LOG_CRIT, "user %s cracked root", user)); */ +-#ifdef ENABLE_NLS ++#if 1 ++#define SYSLOG(x) ++#elif ENABLE_NLS + /* Temporarily set LC_TIME to "C" to avoid strange dates in syslog. + This is a workaround for a more general syslog(d) design problem - + syslogd should log the current system time for each event, and not diff --git a/meta/recipes-extended/shadow/shadow_4.17.2.bb b/meta/recipes-extended/shadow/shadow_4.17.2.bb index 5459d4e57f..19512f2594 100644 --- a/meta/recipes-extended/shadow/shadow_4.17.2.bb +++ b/meta/recipes-extended/shadow/shadow_4.17.2.bb @@ -23,6 +23,7 @@ SRC_URI:append:class-target = " \ SRC_URI:append:class-native = " \ file://commonio.c-fix-unexpected-open-failure-in-chroot-env.patch \ + file://disable_syslog.patch \ " SRC_URI[sha256sum] = "064a7c048e613ef5b5f3613e137d79d35d062ab434e89020f743e90844ec5c4f" UPSTREAM_CHECK_REGEX = "releases/tag/v?(?P\d+(\.\d+)+)$"