mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-05-30 00:20:08 +00:00
Code Issues Projects Releases Wiki Activity

Allow use of dash as /bin/sh

Browse Source 
We've had the check for dash as /bin/sh for a long time. Dash has been
around long enough now that most major issues have been identified and
fixed from  build perspective.

This patch fixes a bashism in the openjade-native recipe. It also
adjusts libtool so that the header at the script is used and not the
value of $SHELL. This is because many Makefiles change $SHELL so dash
can get used to execute what is otherwise configured as a bash shell
script. Since we don't need to execute scripts this way on any system I'm
aware of us building upon, the simplest fix is just to remove $SHELL.

With these two changes the dash check can be removed and we can allow
builds with dash as /bin/sh

(From OE-Core rev: 07ded02ffd37b4fe60a6210dbf56490ea306f0b6)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

[Note: I know I need to add the description of the libtool change above
into the prefix.patch]
This commit is contained in:
Richard Purdie
2011-11-08 21:33:53 +00:00
parent d9740cdcd7
commit 5d3860f4a8
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta/recipes-devtools/libtool/libtool/prefix.patch
+10 -1
View File
@@ -8,6 +8,15 @@ Originally by: RP
Updated: Date: 2010/06/28
Nitin A Kamble <nitin.a.kamble@intel.com>
It also adjusts libtool so that the header at the script is used for
script execution and not thevalue of $SHELL. This is because many
Makefiles change $SHELL so dash can get used to execute what is
otherwise configured as a bash shell script. Since we don't need to
execute scipts this way on any system I'm aware of us building upon,
the simplest fix is just to remove $SHELL.
Updated: Date: 2011/11/09
RP
Index: libtool-2.4/libltdl/m4/libtool.m4
===================================================================
@@ -18,7 +27,7 @@ Index: libtool-2.4/libltdl/m4/libtool.m4
# Always use our own libtool.
-LIBTOOL='$(SHELL) $(top_builddir)/libtool'
+LIBTOOL='$(SHELL) $(top_builddir)'
+LIBTOOL='$(top_builddir)'
+LIBTOOL="$LIBTOOL/${host_alias}-libtool"
AC_SUBST(LIBTOOL)dnl