From 5ef61d10d30deca3e0774554212c2d274306763e Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Wed, 22 May 2024 16:11:23 +0100 Subject: [PATCH] insane: Add error for B = WORKDIR This was never a good idea and would have mostly happened from S = WORKDIR however explictly disallow it and error if anyone tries. (From OE-Core rev: e3c2c1fac904bb518d85e10a2ac0177c81cbf7e8) Signed-off-by: Richard Purdie --- meta/classes-global/insane.bbclass | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index eeef43d00e..42ed1a24a7 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1603,9 +1603,12 @@ python () { oe.qa.handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d) sourcedir = d.getVar("S") + builddir = d.getVar("B") workdir = d.getVar("WORKDIR") if sourcedir == workdir: bb.fatal("Using S = ${WORKDIR} is no longer supported") + if builddir == workdir: + bb.fatal("Using B = ${WORKDIR} is no longer supported") # Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder # why it doesn't work.