mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-06-01 13:09:50 +00:00
Code Issues Projects Releases Wiki Activity

insane.bbclass: Fix incorrect getVar call

Browse Source 
On a trace I was a bit puzzled why getVar was making 180 calls to len(d).
This is an expensive operation that should be very rarely called and
certainly not by getVar. In perl's do_package it was resulting in
~1.5 million function calls from those 180 cases.

Ultimately this typo was why. Lets fix it and save the CPU cyles.

(From OE-Core rev: a8ba821d0002e4395fc5c80649fe14f93a7971fe)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2013-01-29 13:39:08 +00:00
parent b01b1a704b
commit 643bac1e97
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta/classes/insane.bbclass
+1 -1
View File
@@ -404,7 +404,7 @@ def package_qa_check_arch(path,name,d, elf, messages):
target_os = d.getVar('TARGET_OS', True) target_os = d.getVar('TARGET_OS', True)
target_arch = d.getVar('TARGET_ARCH', True) target_arch = d.getVar('TARGET_ARCH', True)
provides = d.getVar('PROVIDES', d, True) provides = d.getVar('PROVIDES', True)
bpn = d.getVar('BPN', True) bpn = d.getVar('BPN', True)
# FIXME: Cross package confuse this check, so just skip them # FIXME: Cross package confuse this check, so just skip them