mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-06-01 13:09:50 +00:00
Code Issues Projects Releases Wiki Activity

bitbake: toaster: fix span2 headings for packages

Browse Source 
[YOCTO 6147]

Fix bug in views.py that put 'span2' class id in a 'clclass' key
instead of the 'dclass' key.  This fix exposed another problem in
target.html and the target view function that used 'package_size'
instead of 'size' as the 'clclass' which is inconsistent with the
model field name, causing table data columns to be shown when
the header is hidden.

(Bitbake rev: 17183bf7cb539287da7234d296da8e3f8fcf1069)

Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Dave Lerner
2014-04-11 17:19:28 -05:00
committed by Richard Purdie
parent 153787d4df
commit 6d0ae0ef44
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bitbake/lib/toaster/toastergui/templates/target.html
+1 -1
View File
@@ -79,7 +79,7 @@
{{package.version|filtered_packageversion:package.revision}} {{package.version|filtered_packageversion:package.revision}}
</a> </a>
</td> </td>
<td class="package-size sizecol"> <td class="size sizecol">
{{package.size|filtered_installedsize:package.installed_size|filtered_filesizeformat}} {{package.size|filtered_installedsize:package.installed_size|filtered_filesizeformat}}
</td> </td>
<td class="size_over_total sizecol"> <td class="size_over_total sizecol">
bitbake/lib/toaster/toastergui/views.py
+6 -3
View File
@@ -575,13 +575,15 @@ def target(request, build_id, target_id):
'qhelp':'The size of the package', 'qhelp':'The size of the package',
'orderfield': _get_toggle_order(request, "size", True), 'orderfield': _get_toggle_order(request, "size", True),
'ordericon':_get_toggle_order_icon(request, "size"), 'ordericon':_get_toggle_order_icon(request, "size"),
'clclass': 'package_size span2', 'clclass': 'size',
'dclass' : 'span2',
'hidden' : 0, 'hidden' : 0,
}, },
{ {
'name':'Size over total (%)', 'name':'Size over total (%)',
'qhelp':'Proportion of the overall included package size represented by this package', 'qhelp':'Proportion of the overall included package size represented by this package',
'clclass': 'size_over_total span2', 'clclass': 'size_over_total',
'dclass' : 'span2',
'hidden' : 1, 'hidden' : 1,
}, },
{ {
@@ -1273,7 +1275,8 @@ def bpackage(request, build_id):
'qhelp':'The size of the package', 'qhelp':'The size of the package',
'orderfield': _get_toggle_order(request, "size", True), 'orderfield': _get_toggle_order(request, "size", True),
'ordericon':_get_toggle_order_icon(request, "size"), 'ordericon':_get_toggle_order_icon(request, "size"),
'clclass': 'size span2', 'hidden': 0, 'clclass': 'size', 'hidden': 0,
'dclass' : 'span2',
}, },
{ {
'name':'License', 'name':'License',