From 7b3a83f7369f9688109fd19394f0b6998dd6eae7 Mon Sep 17 00:00:00 2001 From: Quentin Schulz Date: Thu, 14 Apr 2022 13:33:25 +0200 Subject: [PATCH] docs: sphinx-static: switchers.js.in: remove duplicate for outdated versions Since commit f2b069be8c307 "set_versions: Various improvements", an outdated version will always appear in all_versions, meaning there'll always be an exact match in the loop (just above the git context of this patch) so there's no need to add the current_version to the dropdown menu manually. This issue showed up only for outdated versions of obsolete releases, e.g. 3.2.3. In that case, 3.2.4 (latest version of the obsolete release) will appear in the all_versions array in addition to 3.2.3, which means the check on release series (3.2) will be matched twice, and 3.2.3 will be printed once in the 3.2.4 loop because version != current_version and once in the 3.2.3 because it is an exact match to an entry in all_versions. Cc: Quentin Schulz (From yocto-docs rev: 05065fa1f3855e8b7d9e8af0502b4ae402273400) Signed-off-by: Quentin Schulz Signed-off-by: Richard Purdie --- documentation/sphinx-static/switchers.js.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/documentation/sphinx-static/switchers.js.in b/documentation/sphinx-static/switchers.js.in index 5d3a4d7935..e7ef2ce5f5 100644 --- a/documentation/sphinx-static/switchers.js.in +++ b/documentation/sphinx-static/switchers.js.in @@ -72,9 +72,6 @@ by https://git.yoctoproject.org/yocto-autobuilder-helper/tree/scripts/run-docs-b buf.push(''); else buf.push(''); - - if (version != current_version) - buf.push(''); } else { buf.push(''); }