mirror of
https://git.yoctoproject.org/poky
synced 2026-06-01 13:09:50 +00:00
tcl: fix race in interp.test
There's a timeout race in interp which is exposed when running under load. (From OE-Core rev: bcd792270676beeac73f3900346184dec24d00a1) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
3a4da0d8f7
commit
b59f420dea
@@ -0,0 +1,32 @@
|
||||
The interp-36.7 patch has race conditions and is missing cleanup. This patch by
|
||||
a Tcl maintainer should improve matters.
|
||||
|
||||
Upstream-Status: Pending
|
||||
Signed-off-by: Ross Burton <ross.burton@arm.com>
|
||||
|
||||
diff --git a/tests/interp.test b/tests/interp.test
|
||||
index d7424847f..fc90990f3 100644
|
||||
--- a/tests/interp.test
|
||||
+++ b/tests/interp.test
|
||||
@@ -3595,17 +3595,18 @@ test interp-36.7 {ChildBgerror sets error handler of child [1999035]} -setup {
|
||||
variable result
|
||||
set result [lindex $args 0]
|
||||
}
|
||||
+ set tout [after 5000 {set result timeout}]
|
||||
} -body {
|
||||
child eval {
|
||||
variable done {}
|
||||
after 0 error foo
|
||||
- after 10 [list ::set [namespace which -variable done] {}]
|
||||
- vwait [namespace which -variable done]
|
||||
}
|
||||
+ vwait result
|
||||
set result
|
||||
} -cleanup {
|
||||
+ after cancel $tout
|
||||
variable result {}
|
||||
- unset -nocomplain result
|
||||
+ unset -nocomplain result tout
|
||||
interp delete child
|
||||
} -result foo
|
||||
|
||||
Reference in New Issue
Block a user