From c077a12e49029a6873d36ed25fbedb36a35505be Mon Sep 17 00:00:00 2001 From: Chen Qi Date: Mon, 24 Feb 2025 22:48:52 -0800 Subject: [PATCH] bitbake: data_smart.py: simple clean up When var matches __setvar_regexp__, which has the value as below, __setvar_regexp__ = re.compile(r'(?P.*?)(?P:append|:prepend|:remove)(:(?P[^A-Z]*))?$') the keyword will not be __doc__ or __module__ and var will always contain ":". (Bitbake rev: 0af396917fe176df7b1ed0bd7c7267507ed12e03) Signed-off-by: Chen Qi Signed-off-by: Richard Purdie --- bitbake/lib/bb/data_smart.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py index fa7ddef74a..77a3fd602f 100644 --- a/bitbake/lib/bb/data_smart.py +++ b/bitbake/lib/bb/data_smart.py @@ -580,12 +580,10 @@ class DataSmart(MutableMapping): else: loginfo['op'] = keyword self.varhistory.record(**loginfo) - # todo make sure keyword is not __doc__ or __module__ # pay the cookie monster # more cookies for the cookie monster - if ':' in var: - self._setvar_update_overrides(base, **loginfo) + self._setvar_update_overrides(base, **loginfo) if base in self.overridevars: self._setvar_update_overridevars(var, value)