From c2aec3f86ccd2dbe6185f3df2b22a6873582b457 Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Wed, 23 Apr 2025 18:26:41 +0100 Subject: [PATCH] uninative: show errors if installing fails We call the installer script but if it fails the user doesn't see the reason, which makes resolving the problem hard. Capture both stdout and stderr as text, and display it to the user when it fails. (From OE-Core rev: c67fbe17ce063350181c28f99662004737d8b770) Signed-off-by: Ross Burton Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- meta/classes-global/uninative.bbclass | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/meta/classes-global/uninative.bbclass b/meta/classes-global/uninative.bbclass index d2297b53f5..75e0c19704 100644 --- a/meta/classes-global/uninative.bbclass +++ b/meta/classes-global/uninative.bbclass @@ -109,7 +109,7 @@ ${UNINATIVE_STAGING_DIR}-uninative/relocate_sdk.py \ ${UNINATIVE_LOADER} \ ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux/${bindir_native}/patchelf-uninative \ ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux${base_libdir_native}/libc*.so*" % chksum) - subprocess.check_output(cmd, shell=True) + subprocess.check_output(cmd, shell=True, text=True, stderr=subprocess.STDOUT) with open(loaderchksum, "w") as f: f.write(chksum) @@ -122,7 +122,9 @@ ${UNINATIVE_STAGING_DIR}-uninative/relocate_sdk.py \ bb.warn("Disabling uninative as unable to fetch uninative tarball: %s" % str(exc)) bb.warn("To build your own uninative loader, please bitbake uninative-tarball and set UNINATIVE_TARBALL appropriately.") except subprocess.CalledProcessError as exc: - bb.warn("Disabling uninative as unable to install uninative tarball: %s" % str(exc)) + bb.warn("Disabling uninative as unable to install uninative tarball:") + bb.warn(str(exc)) + bb.warn(exc.stdout) bb.warn("To build your own uninative loader, please bitbake uninative-tarball and set UNINATIVE_TARBALL appropriately.") finally: os.chdir(olddir)