mirror of
https://git.yoctoproject.org/poky
synced 2026-06-01 00:59:48 +00:00
curl: Security fix for CVE-2016-8615
Affected versions: curl 7.1 to and including 7.50.3 Not affected versions: curl >= 7.51.0 (From OE-Core rev: b754be84206b454789fbd6d444d00a4e422cb3e9) Signed-off-by: Thiruvadi Rajaraman <trajaraman@mvista.com> Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
a5cbc746fa
commit
c8ebaaaf8d
@@ -0,0 +1,71 @@
|
|||||||
|
From 1620f552a277ed5b23a48b9c27dbf07663cac068 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Daniel Stenberg <daniel@haxx.se>
|
||||||
|
Date: Tue, 27 Sep 2016 17:36:19 +0200
|
||||||
|
Subject: [PATCH] cookie: replace use of fgets() with custom version
|
||||||
|
|
||||||
|
... that will ignore lines that are too long to fit in the buffer.
|
||||||
|
|
||||||
|
CVE-2016-8615
|
||||||
|
|
||||||
|
Bug: https://curl.haxx.se/docs/adv_20161102A.html
|
||||||
|
Reported-by: Cure53
|
||||||
|
|
||||||
|
Upstream-Status: Backport
|
||||||
|
https://curl.haxx.se/CVE-2016-8615.patch
|
||||||
|
|
||||||
|
CVE: CVE-2016-8615
|
||||||
|
Signed-off-by: Thiruvadi Rajaraman <trajaraman@mvista.com>
|
||||||
|
|
||||||
|
---
|
||||||
|
lib/cookie.c | 31 ++++++++++++++++++++++++++++++-
|
||||||
|
1 file changed, 30 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
Index: curl-7.44.0/lib/cookie.c
|
||||||
|
===================================================================
|
||||||
|
--- curl-7.44.0.orig/lib/cookie.c
|
||||||
|
+++ curl-7.44.0/lib/cookie.c
|
||||||
|
@@ -869,6 +869,35 @@ Curl_cookie_add(struct SessionHandle *da
|
||||||
|
return co;
|
||||||
|
}
|
||||||
|
|
||||||
|
+/*
|
||||||
|
+ * get_line() makes sure to only return complete whole lines that fit in 'len'
|
||||||
|
+ * bytes and end with a newline.
|
||||||
|
+ */
|
||||||
|
+static char *get_line(char *buf, int len, FILE *input)
|
||||||
|
+{
|
||||||
|
+ bool partial = FALSE;
|
||||||
|
+ while(1) {
|
||||||
|
+ char *b = fgets(buf, len, input);
|
||||||
|
+ if(b) {
|
||||||
|
+ size_t rlen = strlen(b);
|
||||||
|
+ if(rlen && (b[rlen-1] == '\n')) {
|
||||||
|
+ if(partial) {
|
||||||
|
+ partial = FALSE;
|
||||||
|
+ continue;
|
||||||
|
+ }
|
||||||
|
+ return b;
|
||||||
|
+ }
|
||||||
|
+ else
|
||||||
|
+ /* read a partial, discard the next piece that ends with newline */
|
||||||
|
+ partial = TRUE;
|
||||||
|
+ }
|
||||||
|
+ else
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+ return NULL;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
/*****************************************************************************
|
||||||
|
*
|
||||||
|
* Curl_cookie_init()
|
||||||
|
@@ -925,7 +954,7 @@ struct CookieInfo *Curl_cookie_init(stru
|
||||||
|
line = malloc(MAX_COOKIE_LINE);
|
||||||
|
if(!line)
|
||||||
|
goto fail;
|
||||||
|
- while(fgets(line, MAX_COOKIE_LINE, fp)) {
|
||||||
|
+ while(get_line(line, MAX_COOKIE_LINE, fp)) {
|
||||||
|
if(checkprefix("Set-Cookie:", line)) {
|
||||||
|
/* This is a cookie line, get it! */
|
||||||
|
lineptr=&line[11];
|
||||||
@@ -12,7 +12,9 @@ SRC_URI = "http://curl.haxx.se/download/curl-${PV}.tar.bz2 \
|
|||||||
# curl likes to set -g0 in CFLAGS, so we stop it
|
# curl likes to set -g0 in CFLAGS, so we stop it
|
||||||
# from mucking around with debug options
|
# from mucking around with debug options
|
||||||
#
|
#
|
||||||
SRC_URI += " file://configure_ac.patch"
|
SRC_URI += " file://configure_ac.patch \
|
||||||
|
file://CVE-2016-8615.patch \
|
||||||
|
"
|
||||||
|
|
||||||
SRC_URI[md5sum] = "015f6a0217ca6f2c5442ca406476920b"
|
SRC_URI[md5sum] = "015f6a0217ca6f2c5442ca406476920b"
|
||||||
SRC_URI[sha256sum] = "3c12c5f54ccaa1d40abc65d672107dcc75d3e1fcb38c267484334280096e5156"
|
SRC_URI[sha256sum] = "3c12c5f54ccaa1d40abc65d672107dcc75d3e1fcb38c267484334280096e5156"
|
||||||
|
|||||||
Reference in New Issue
Block a user