mirror of
https://git.yoctoproject.org/poky
synced 2026-06-01 13:09:50 +00:00
qemu: Security fix CVE-2015-7504
CVE-2015-7504 Qemu: net: pcnet: heap overflow vulnerability in loopback mode (From OE-Core rev: b01b569d7d7e651a35fa38750462f13aeb64a2f3) (From OE-Core rev: 10752d6beb5520ec0fc83a7d0173e10144b11685) Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
73941fbc6a
commit
caa104fd2a
@@ -0,0 +1,56 @@
|
|||||||
|
From 837f21aacf5a714c23ddaadbbc5212f9b661e3f7 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Prasad J Pandit <pjp@fedoraproject.org>
|
||||||
|
Date: Fri, 20 Nov 2015 11:50:31 +0530
|
||||||
|
Subject: [PATCH] net: pcnet: add check to validate receive data
|
||||||
|
size(CVE-2015-7504)
|
||||||
|
|
||||||
|
In loopback mode, pcnet_receive routine appends CRC code to the
|
||||||
|
receive buffer. If the data size given is same as the buffer size,
|
||||||
|
the appended CRC code overwrites 4 bytes after s->buffer. Added a
|
||||||
|
check to avoid that.
|
||||||
|
|
||||||
|
Reported by: Qinghao Tang <luodalongde@gmail.com>
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
|
||||||
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
|
||||||
|
Upstream-Status: Backport
|
||||||
|
|
||||||
|
http://git.qemu.org/?p=qemu.git;a=commit;h=837f21aacf5a714c23ddaadbbc5212f9b661e3f7
|
||||||
|
|
||||||
|
CVE: CVE-2015-7504
|
||||||
|
[Yocto # 9013]
|
||||||
|
|
||||||
|
Signed-off-by: Armin Kuster <akuster@mvista.com>
|
||||||
|
|
||||||
|
---
|
||||||
|
hw/net/pcnet.c | 8 +++++---
|
||||||
|
1 file changed, 5 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
Index: qemu-2.2.0/hw/net/pcnet.c
|
||||||
|
===================================================================
|
||||||
|
--- qemu-2.2.0.orig/hw/net/pcnet.c
|
||||||
|
+++ qemu-2.2.0/hw/net/pcnet.c
|
||||||
|
@@ -1106,7 +1106,7 @@ ssize_t pcnet_receive(NetClientState *nc
|
||||||
|
uint32_t fcs = ~0;
|
||||||
|
uint8_t *p = src;
|
||||||
|
|
||||||
|
- while (p != &src[size-4])
|
||||||
|
+ while (p != &src[size])
|
||||||
|
CRC(fcs, *p++);
|
||||||
|
crc_err = (*(uint32_t *)p != htonl(fcs));
|
||||||
|
}
|
||||||
|
@@ -1255,8 +1255,10 @@ static void pcnet_transmit(PCNetState *s
|
||||||
|
bcnt = 4096 - GET_FIELD(tmd.length, TMDL, BCNT);
|
||||||
|
|
||||||
|
/* if multi-tmd packet outsizes s->buffer then skip it silently.
|
||||||
|
- Note: this is not what real hw does */
|
||||||
|
- if (s->xmit_pos + bcnt > sizeof(s->buffer)) {
|
||||||
|
+ * Note: this is not what real hw does.
|
||||||
|
+ * Last four bytes of s->buffer are used to store CRC FCS code.
|
||||||
|
+ */
|
||||||
|
+ if (s->xmit_pos + bcnt > sizeof(s->buffer) - 4) {
|
||||||
|
s->xmit_pos = -1;
|
||||||
|
goto txdone;
|
||||||
|
}
|
||||||
@@ -21,6 +21,7 @@ SRC_URI += "file://configure-fix-Darwin-target-detection.patch \
|
|||||||
file://11-xen-pt-unknown-PCI-config-space-fields-should-be-readonly-CVE-2015-4106.patch \
|
file://11-xen-pt-unknown-PCI-config-space-fields-should-be-readonly-CVE-2015-4106.patch \
|
||||||
file://qemu-fix-CVE-2015-3209.patch \
|
file://qemu-fix-CVE-2015-3209.patch \
|
||||||
file://CVE-2015-8504.patch \
|
file://CVE-2015-8504.patch \
|
||||||
|
file://CVE-2015-7504.patch \
|
||||||
"
|
"
|
||||||
SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
|
SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
|
||||||
SRC_URI[md5sum] = "f7a5e2da22d057eb838a91da7aff43c8"
|
SRC_URI[md5sum] = "f7a5e2da22d057eb838a91da7aff43c8"
|
||||||
|
|||||||
Reference in New Issue
Block a user