mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-05-30 12:29:55 +00:00
Code Issues Projects Releases Wiki Activity

bitbake: server/process: Use a pipe for quit events instead of Event()

Browse Source 
Its not possible to notice the change of status of an Event() in
the select call we sleep in. It would be possible in python 3.3 but
for now use a pipe instead. This removes small latency when bitbake
commands finish since the system doesn't sit in the select call.

(Debugging these kind of issues is apparent by setting a long sleep
for the select call)

(Bitbake rev: def28239b0f0d5f1cf13214b263114a5328538b7)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2014-03-09 17:58:02 -07:00
parent a445e03d8b
commit efdc1598d2
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bitbake/lib/bb/server/process.py
+9 -5
View File
@@ -87,8 +87,7 @@ class ProcessServer(Process, BaseImplServer):
self.featurelist = featurelist self.featurelist = featurelist
self.quit = False self.quit = False
self.keep_running = Event() self.quitin, self.quitout = Pipe()
self.keep_running.set()
self.event_handle = multiprocessing.Value("i") self.event_handle = multiprocessing.Value("i")
def run(self): def run(self):
@@ -101,14 +100,18 @@ class ProcessServer(Process, BaseImplServer):
def main(self): def main(self):
# Ignore SIGINT within the server, as all SIGINT handling is done by # Ignore SIGINT within the server, as all SIGINT handling is done by
# the UI and communicated to us # the UI and communicated to us
self.quitin.close()
signal.signal(signal.SIGINT, signal.SIG_IGN) signal.signal(signal.SIGINT, signal.SIG_IGN)
while self.keep_running.is_set(): while not self.quit:
try: try:
if self.command_channel.poll(): if self.command_channel.poll():
command = self.command_channel.recv() command = self.command_channel.recv()
self.runCommand(command) self.runCommand(command)
if self.quitout.poll():
self.quitout.recv()
self.quit = True
self.idle_commands(.1, [self.event_queue._reader, self.command_channel]) self.idle_commands(.1, [self.event_queue._reader, self.command_channel, self.quitout])
except Exception: except Exception:
logger.exception('Running command %s', command) logger.exception('Running command %s', command)
@@ -147,7 +150,8 @@ class ProcessServer(Process, BaseImplServer):
self.command_channel.send(self.cooker.command.runCommand(command)) self.command_channel.send(self.cooker.command.runCommand(command))
def stop(self): def stop(self):
self.keep_running.clear() self.quitin.send("quit")
self.quitin.close()
class BitBakeProcessServerConnection(BitBakeBaseServerConnection): class BitBakeProcessServerConnection(BitBakeBaseServerConnection):
def __init__(self, serverImpl, ui_channel, event_queue): def __init__(self, serverImpl, ui_channel, event_queue):