A recent round of informal user feedback has revealed
that the term 'target' is quite problematic. For
all the users we spoke to the word refers to the
target arch. In Toaster, it refers to the software
you build.
This patch replaces the word 'target' with 'recipe'
across the Toaster interface. This is by no means
self-explanatory, but at least it cannot be confused
with target hardware, and it is also consistent with
the terminology we use in the analysis portion of
the interface.
(Bitbake rev: ac10b5d83172feb10f1f3a3c894a54d2c4c4f09d)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fixes for the following for the "Most built targets" section of the
project page:
1) limit the number of most built targets to 5,
2) order the list of most built targets by build count,
3) select only those builds that had build status of 'fail', 'success',
or a BuildRequest of 'failed',
4) if there are no layers in the project then (on refresh) all of the
checkboxes in the 'Most built targets' list are disabled.
Note that per agreement with UI designer, the only sort on the most
target list is build count as described in (3) above; secondary sorting
is random.
[YOCTO #7177]
(Bitbake rev: dda2f07193e740860f4497c3761d340d8c5c2b41)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
A typo in some element selectors caused the package_rpm setup to break.
[YOCTO #7448]
(Bitbake rev: 0479faa46f0364df6d8e151be34e1834076df49d)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit:
* Makes some changes to the layout and styles of the
landing.html template
* Adds the empty state to layers.html
* Changes the message of the empty state of machines.html
to use the same wording used in all other pages
* Adds the project name and the right styles to
the empty state of the project.html template
* Makes small changes in style and wording to the
empty state of targets.html
* Updates all "configure a layer source" links to point
to the new Toaster manual.
(Bitbake rev: d886db3add1351a806ab58ec7519d2321687187b)
Signed-off-by: Belen Barros Pena <belen.barros.pena@linux.intel.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Explain that, if information is found during the build
process, it will appear in the layer details page.
(Bitbake rev: 40b46ce28b0b93241f9ce581f1e295e95bbff284)
Signed-off-by: Belen Barros Pena <belen.barros.pena@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If only one release has been set up in Toaster,
any project you create defaults to that release,
and we simply don't show the release selection
menu when creating projects.
However, we were still showing the release information
in the project page, which would leave users wondering
what that release thing is since they never were
exposed to it.
This patch hides the release information in the
project page when only one release has been set
up in Toaster.
(Bitbake rev: 0bd81be04c88104d7d460f913d0500e5fa9755fe)
Signed-off-by: Belen Barros Pena <belen.barros.pena@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Set the links to the Toaster manual in the base.html
and landing_not_managed.html templates to the URL of
the new Toaster manual.
(Bitbake rev: 88b1201a2f6dec53970b120cc8e13c0eb5ae21e1)
Signed-off-by: Belen Barros Pena <belen.barros.pena@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Remove the branch name from the list of the layers
deleted (it does not apply).
* In the modal dialog that warns you before layer
deletion, use the release description instead of
the release name
(Bitbake rev: b4ffe490253108e7a009290474e206468255ce12)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Enable date range selections for build start and build complete in all
builds page for both managed and interactive mode. Disable the filter
counts.
[YOCTO #6040]
[YOCTO #7249]
[YOCTO #7461]
(Bitbake rev: 7c86ed5fb51c6237fa40fb454e58564ef027dd51)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The 'Last build' column in the all projects table
was supposed to provide the completion time stamp
of the latest project build. Instead, it is showing
the time stamp of the latest project activity, which
includes:
* when the project was created and
* when the last build started
but not when you make a change to the configuration.
The result is that the column and the sorting are very
misleading. The template is set so that the time stamp
only shows when the project has builds (if 0 builds, no
time stamp is shown). But of course the sorting still
happens according to the value, even if it doesn't
display. The result is that, when you sort by the
'Last build' column, projects with no builds
appear listed between projects with builds, and you
have no idea why.
This patch:
* changes the column label
* its position in the table
* makes sure the time stamp always displays
* and adds help text
to reflect what the data actually means.
It also makes some small changes to other table
headings.
(Bitbake rev: 994b19ef7f633b8d463efa7022f2e17cd483a387)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make sure we point to the all targets page for the notification links.
Also fix the tooltip placements and a minor typo on the targets page.
[YOCTO #7480]
(Bitbake rev: cbf3d652dcbfc1db527eb13cd796fa57d8ff3748)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change bitbake variables table to show the path to the file in which
the variable was defined using a layer-relative path instead of the
full path to the file.
The layer-relative path is found by matching on the full defining file
path with entries in a list of layer names, sorted in descending order,
and with 'meta' appended as a built-in layer to the end of the list.
Additional filters are used to reduce false matches, although even if
there is a false match, the actual path to the defining file will be
obvious and not misleading.
[YOCTO #7414]
(Bitbake rev: ef6e854a50ea6894b0e320025280431a6fc8a9a5)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In the 'add variable' form, the submit button had
a class applied that gave it straight corners on the
left, and rounded corners on the right.
Remove the class so that we have 4 nicely rounded corners.
The patch also removes the unncessary inline styles in the
same button.
(Bitbake rev: 4f2a6d5b515dec4b6199cc4517cd13dcc331f3c3)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When the IMAGE_INSTALL_append value is not empty, it must have a space prefix
in order for the "append" operator to concatenate the values correctly, so we
enforce it in this variable's submit javascript.
[YOCTO #7394]
(Bitbake rev: fc0cec1f38aa6f2d09434cc008a429d350a5706f)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Explicitly preset the machine and project values in their respective
input fields.
[YOCTO #7170]
(Bitbake rev: 23c83c6a8af12ad1c008372685f7cd9f87023145)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add this functionality to the common managed_mrb_section
Make sure we are using the correct version of this template in the
projects template and remove now redundant code.
[YOCTO #7351]
(Bitbake rev: 23f1439a5d3e8f4053826794c6502eca20189054)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The last item in the breadcrumb for the project page should not be a link.
[YOCTO #7157]
(Bitbake rev: 6966d68e650c2d5655a1e747e70d35f5f037dc94)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When you click the 'change' icon to edit the project release, the
"cancel" button, should always be enabled so that the user can
return to the 'not editable' state at any time.
[YOCTO #7151]
(Bitbake rev: adcd24b97ea78fbccb870d62bd1297edae3a3487)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We replace the ETA (which was an inaccurate estimation)
with the percentage of completed tasks.
(Bitbake rev: 220f5b853fd3236b49faa5ec54c9c96050a84fa9)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The button for error-ed builds had invalid javascript markup,
this patch fixes the buttons.
(Bitbake rev: 2824888196acc5cbe326b18148581472772ab21d)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch brings in a new set of optimizations in the tables pages,
with the focus of reducing the number of SQL queries performed per
row.
(Bitbake rev: a1ad86febb9d8a4ee7f15aa726f267d64b8e0dc4)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We improve the data suggestions in the project page.
The machines suggestions now contain the layer name.
The targets and machine do not show the layer branch.
For targets, the layer name is searchable.
For machines, the description field is searchable.
[YOCTO #7153]
[YOCTO #7154]
(Bitbake rev: 02a4997807ee995817d741985eea13d38e548007)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change inconsistent branch name usage in project page to
the uniquely defined get_vcs_reference()
[YOCTO #7381]
(Bitbake rev: bc838a6c075c4d7e24f7820088f485bbfdea5a32)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We modify the project page to provide a consistent view of the
build errors. The display is now similar with the
managed_mrb_section and links point to the buildrequest
detail view.
[YOCTO #7188]
(Bitbake rev: d37eaaa48a63a137ded25a14911c97a5ae861ff6)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When a task is executed successfully without using saved-state cache,
then a button appears allowing the user to download the log file for
that task. This commit allows the user to download the log file for a
task that is completed by unpacking data from the saved-state cache, a
task with outcome 'Cached'. The same button 'Download task log' is
shown, which when pressed downloads the '_setscene' log file for that
task.
[YOCTO #7379]
(Bitbake rev: d4ac60c41f1ee9a8c59f9ede5b0948303f793afa)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make it slightly shorter, and separate the 'back' action
so that is more visible and easier to hit.
(Bitbake rev: 70c8d8f471653e6832d1bbc469914b7e59372c1b)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In the build dashboard, the download build log button was
a bit too close to the build time.
(Bitbake rev: da7c450f28cdf1c851b14f7a1fac08e6cf1dd894)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Failed builds were showing the target name with the .success
class applied (cognitive disonance, anyone?).
(Bitbake rev: c78a19ecd2b397ccce59c1f6b852953b04afd37a)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In the project page, the project layer links were opening
in a new tab. They should not do that.
(Bitbake rev: 45d3c27e68149bce089551539f6bbdaef98b7896)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We had some clever functionality to manage duplicate layer names by
using layer versions and new revisions, unfortunately this was too
opaque to the user.
[YOCTO #7337]
(Bitbake rev: 4590cfcb2d5e26518e04f8abc8e7c2dad973f6d2)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
On the layers page, when a layer revision is a commit id instead of a
an upstream branch name, then follow the same format for displaying the
commit id as on the recipes page. That format is a button with the
truncated commit SHAID which when pressed expands to the full SHAID.
[YOCTO #7191]
(Bitbake rev: 507d2a36e53ba2c1f49616d52e4700f6c1bca8fd)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Some URLs, although invalid on their own, are used in JS to
build valid page pointers. Previous patch removed two of these URLs,
breaking the display of several patches.
This patch re-adds these URLs with different names, and returns
400 Bad Request empty pages on them, which is consistent with the
intended usage of these URLs.
(Bitbake rev: 73afee5ddb2e89dcec65854639b19b8860232d89)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hide the special config variable management sections when the respective
variables are not present. Disable the variable add button after a
variable is added so that blank values cannot be added, and also when a
variable name managed in the project detail page (e.g. BBLAYERS and MACHINE)
is entered.
[YOCTO #7246]
[YOCTO #7371]
(Bitbake rev: 1f9aaa7747351f7b0063f80c56cf7fa2c9cc3cf9)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
On the heading for the layer detail page, only show a tool tip on the
heading revision branch/shaid field if the string is too large to fit
in the 13 character field. That is, don't show a hovering tool tip
with exactly the same string that is shown without the tip.
[YOCTO #7312]
(Bitbake rev: 8a3095a33551a96176fdff83ea33cda5b30311dd)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When selecting the packages tab on a recipe detail page, the page now
includes:
column sort on package name and size columns,
search on the package name, and
pagination.
Column sort is added by splitting the recipe view/html for a recipe's
package list into a new url path, view name and template, so that
the sorting routine, views.reload_params(), interfaces similar to other
views.
Search, sorting, and pagination are implemented for this detail page
using three new templates.
templates/detail_pagination_bottom.html
templates/detail_search_header.html
templates/detail_sorted_header.html
views.recipe() is optimized since the recipe's package list is no
longer needed by the recipe template, only the recipe's package count
is required for the first page.
The recipe view and template also changes to support tabbing to the
right context on the recipe detail page from the recipe-package page.
[YOCTO #6154]
(Bitbake rev: 6cb9e853d05c2c71467af22ef459ffbe6f41de36)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Block duplicates of custom variables regardless of case, fix spacing of
delete icon, no extra error msg on blank DISTRO name
[YOCTO #7359]
(Bitbake rev: baec2940c2b4ec792cacad5cc8d8056d9162919b)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Implement the 'last build' data methods, enhance variable display,
add empty page and empty sort support.
[YOCTO #6682]
(Bitbake rev: cc6ca17e80844ecb4a777276d5f5177ebbcd93f9)
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch adds CSRF tokens in pages using AJAX calls in
order to force Django to generate the CSRF cookie used to
authenticate the call.
(Bitbake rev: 6b2403992f1f5f84114ec9b243813957ff907051)
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We have 2 pages where we have a 'latest builds' section:
the 'all builds / all projects' page and the 'project'
page. Unfortunately, we are currently using different
code base in both, which means that some inconsistencies
between the two in behaviour and presentation have sneaked
in.
This patch addresses some of such inconsistencies.
(Bitbake rev: 0825f1a74b3767aad67674ab5044075c90067377)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When debugging is turned on, we show some Toaster version
information in the top bar. Present it so that it can
be easily copied and pasted.
(Bitbake rev: 5de46fabe9ab1e525048353c2ecd8846ffefc760)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bring the pagination controls into line with others in toaster by
limiting the number of page buttons to 5
[YOCTO #7195]
(Bitbake rev: 0b35eed7ca758476f20d6875291ee31fad35b7d3)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In the machines table for a layer add a link/icon to the machine
definition file.
[YOCTO #7241]
(Bitbake rev: 8c4e5fb580f5e375ccb1e84d8adb9562d1ba4b62)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Allow the descriptions of the machine summary and layer description to
be searchable in their respective tables.
[YOCTO #7199]
(Bitbake rev: 1a1a61f587e05af76299c7e1d3b7ab079fb4b1c1)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The revision label was missing the projec-form class (which
controls the spacing in the form), and the revision text
field was a bit too long, so changed it from span4 to
span3.
(Bitbake rev: 219d57d1cec178820f679a4153324986c37821db)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This wasn't required or working due to a typo and adds ambiguity between
the summary and description. The correct method for changing the description
or summary is via the layerdetails page.
[YOCTO #7190]
(Bitbake rev: 605298ff3ce919127003dadef95798472327f943)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Removes the layer directory information from the packages
built page when in managed mode.
[YOCTO #7221]
(Bitbake rev: 1eaf60d0fe34f5f43386c6f0e91f0b26c7a62845)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In debug mode, we show the Toaster version and mode in the
top bar. Display them inside a tooltip that appears when
you hover over a nice info icon to make them less conspicuous.
(Bitbake rev: 8365f19191d0ec5901c79b7afd5005f7a546fe74)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When the result for the summary or description is None don't output the
result as the string version of None, use an empty value so that the
"Not set" mechanism works.
[YOCTO #7244]
(Bitbake rev: 34397e585df0fc04ea53046347856e8cddb8f8e1)
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Belen Barros Pena
Dave Lerner
David Reyna
Belen Barros Pena
Michael Wood
Alexandru DAMIAN