From 198c801f003da0937ee33194d68d406ace7a71c1 Mon Sep 17 00:00:00 2001 From: Luan Dang <167596399+luanmdang@users.noreply.github.com> Date: Thu, 10 Sep 2026 13:02:02 -0500 Subject: [PATCH] Refactor TestHeadMetrics for improved testing Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- api/api_test.go | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/api/api_test.go b/api/api_test.go index 8b79074d..d545d4e6 100644 --- a/api/api_test.go +++ b/api/api_test.go @@ -160,10 +160,20 @@ func (s *APISuite) TestGetMetrics(c *C) { } func (s *APISuite) TestHeadMetrics(c *C) { - response, err := s.HTTPRequest("HEAD", "/api/metrics", nil) + server := httptest.NewServer(s.router) + defer server.Close() + + req, err := http.NewRequest(http.MethodHead, server.URL+"/api/metrics", nil) c.Assert(err, IsNil) - c.Check(response.Code, Equals, 200) - c.Check(strings.Contains(response.Body.String(), "# TYPE aptly_build_info gauge"), Equals, true) + + resp, err := server.Client().Do(req) + c.Assert(err, IsNil) + defer resp.Body.Close() + + c.Check(resp.StatusCode, Equals, 200) + body, readErr := io.ReadAll(resp.Body) + c.Assert(readErr, IsNil) + c.Check(len(body), Equals, 0) } func (s *APISuite) TestRepoCreate(c *C) {