mirror of
https://github.com/aptly-dev/aptly.git
synced 2026-06-10 06:14:22 +00:00
Merge pull request #449 from adfinis-forks/bug_415_memoryhandling
only create bzip file if needed. #415
This commit is contained in:
+1
-1
@@ -62,7 +62,7 @@ func (file *indexFile) Finalize(signer utils.Signer) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if file.compressable {
|
if file.compressable {
|
||||||
err = utils.CompressFile(file.tempFile)
|
err = utils.CompressFile(file.tempFile, file.onlyGzip)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
file.tempFile.Close()
|
file.tempFile.Close()
|
||||||
return fmt.Errorf("unable to compress index file: %s", err)
|
return fmt.Errorf("unable to compress index file: %s", err)
|
||||||
|
|||||||
+2
-2
@@ -11,7 +11,7 @@ import (
|
|||||||
//
|
//
|
||||||
// It uses internal gzip and external bzip2, see:
|
// It uses internal gzip and external bzip2, see:
|
||||||
// https://code.google.com/p/go/issues/detail?id=4828
|
// https://code.google.com/p/go/issues/detail?id=4828
|
||||||
func CompressFile(source *os.File) error {
|
func CompressFile(source *os.File, onlyGzip bool) error {
|
||||||
gzPath := source.Name() + ".gz"
|
gzPath := source.Name() + ".gz"
|
||||||
gzFile, err := os.Create(gzPath)
|
gzFile, err := os.Create(gzPath)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -24,7 +24,7 @@ func CompressFile(source *os.File) error {
|
|||||||
|
|
||||||
source.Seek(0, 0)
|
source.Seek(0, 0)
|
||||||
_, err = io.Copy(gzWriter, source)
|
_, err = io.Copy(gzWriter, source)
|
||||||
if err != nil {
|
if err != nil || onlyGzip {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -27,7 +27,7 @@ func (s *CompressSuite) TearDownTest(c *C) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (s *CompressSuite) TestCompress(c *C) {
|
func (s *CompressSuite) TestCompress(c *C) {
|
||||||
err := CompressFile(s.tempfile)
|
err := CompressFile(s.tempfile, false)
|
||||||
c.Assert(err, IsNil)
|
c.Assert(err, IsNil)
|
||||||
|
|
||||||
buf := make([]byte, len(testString))
|
buf := make([]byte, len(testString))
|
||||||
|
|||||||
Reference in New Issue
Block a user