From 4bc2180eed8f023d67c9fa5f149d68b8e7ebf20a Mon Sep 17 00:00:00 2001 From: Jens Reinsberger Date: Wed, 8 Nov 2023 15:38:42 +0100 Subject: [PATCH] fix failing build on hosts with wildcard dns on hosts which have wildcard dns domains in their local domain search list, builds failed because "nosuch.host" could actually be resolved. Since ".host" isn't a recommended TLD by RFC2606, we use ".invalid" now. And since this is not enough to fix the problem, we use now absoulte domain names (having a '.' at the end) --- http/download_test.go | 4 ++-- http/grab_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/http/download_test.go b/http/download_test.go index 0579ab1d..9cde0716 100644 --- a/http/download_test.go +++ b/http/download_test.go @@ -115,7 +115,7 @@ func (s *DownloaderSuite) TestDownload404(c *C) { } func (s *DownloaderSuite) TestDownloadConnectError(c *C) { - c.Assert(s.d.Download(s.ctx, "http://nosuch.host/", s.tempfile.Name()), + c.Assert(s.d.Download(s.ctx, "http://nosuch.host.invalid./", s.tempfile.Name()), ErrorMatches, ".*no such host") } @@ -150,7 +150,7 @@ func (s *DownloaderSuite) TestGetLength404(c *C) { } func (s *DownloaderSuite) TestGetLengthConnectError(c *C) { - _, err := s.d.GetLength(s.ctx, "http://nosuch.host/") + _, err := s.d.GetLength(s.ctx, "http://nosuch.host.invalid./") c.Assert(err, ErrorMatches, ".*no such host") } diff --git a/http/grab_test.go b/http/grab_test.go index ca61e5ca..dacdfa8f 100644 --- a/http/grab_test.go +++ b/http/grab_test.go @@ -106,7 +106,7 @@ func (s *GrabDownloaderSuite) TestDownload404(c *C) { } func (s *GrabDownloaderSuite) TestDownloadConnectError(c *C) { - c.Assert(s.d.Download(s.ctx, "http://nosuch.host/", s.tempfile.Name()), + c.Assert(s.d.Download(s.ctx, "http://nosuch.host.invalid./", s.tempfile.Name()), ErrorMatches, ".*no such host") } @@ -130,7 +130,7 @@ func (s *GrabDownloaderSuite) TestGetLength404(c *C) { } func (s *GrabDownloaderSuite) TestGetLengthConnectError(c *C) { - _, err := s.d.GetLength(s.ctx, "http://nosuch.host/") + _, err := s.d.GetLength(s.ctx, "http://nosuch.host.invalid./") c.Assert(err, ErrorMatches, ".*no such host") }