Support for dependencies with fixed archs (like as source dependency).

This commit is contained in:
Andrey Smirnov
2014-02-17 15:36:16 +04:00
parent c2f01c8aa1
commit a0b1ff8abe
2 changed files with 25 additions and 10 deletions
+5 -1
View File
@@ -18,6 +18,8 @@ const (
DepFollowRecommends DepFollowRecommends
// DepFollowAllVariants follows all variants if depends on "a | b" // DepFollowAllVariants follows all variants if depends on "a | b"
DepFollowAllVariants DepFollowAllVariants
// DepFollowBuild pulls build dependencies
DepFollowBuild
) )
// PackageList is list of unique (by key) packages // PackageList is list of unique (by key) packages
@@ -224,7 +226,9 @@ func (l *PackageList) VerifyDependencies(options int, architectures []string, so
missingCount := 0 missingCount := 0
for _, dep := range variants { for _, dep := range variants {
dep.Architecture = arch if dep.Architecture == "" {
dep.Architecture = arch
}
hash := dep.Hash() hash := dep.Hash()
r, ok := cache[hash] r, ok := cache[hash]
+20 -9
View File
@@ -40,7 +40,7 @@ func (s *PackageListSuite) SetUpTest(c *C) {
s.il = NewPackageList() s.il = NewPackageList()
s.packages = []*Package{ s.packages = []*Package{
&Package{Name: "lib", Version: "1.0", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"mail-agent"}}, &Package{Name: "lib", Version: "1.0", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"mail-agent"}},
&Package{Name: "dpkg", Version: "1.7", Architecture: "i386", Provides: []string{"package-installer"}}, &Package{Name: "dpkg", Version: "1.7", Architecture: "i386", Source: "dpkg", Provides: []string{"package-installer"}},
&Package{Name: "data", Version: "1.1~bp1", Architecture: "all", PreDepends: []string{"dpkg (>= 1.6)"}}, &Package{Name: "data", Version: "1.1~bp1", Architecture: "all", PreDepends: []string{"dpkg (>= 1.6)"}},
&Package{Name: "app", Version: "1.1~bp1", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"lib (>> 0.9)", "data (>= 1.0)"}}, &Package{Name: "app", Version: "1.1~bp1", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"lib (>> 0.9)", "data (>= 1.0)"}},
&Package{Name: "mailer", Version: "3.5.8", Architecture: "i386", Provides: []string{"mail-agent"}}, &Package{Name: "mailer", Version: "3.5.8", Architecture: "i386", Provides: []string{"mail-agent"}},
@@ -48,10 +48,11 @@ func (s *PackageListSuite) SetUpTest(c *C) {
&Package{Name: "app", Version: "1.1~bp1", Architecture: "arm", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"lib (>> 0.9) | libx (>= 1.5)", "data (>= 1.0) | mail-agent"}}, &Package{Name: "app", Version: "1.1~bp1", Architecture: "arm", PreDepends: []string{"dpkg (>= 1.6)"}, Depends: []string{"lib (>> 0.9) | libx (>= 1.5)", "data (>= 1.0) | mail-agent"}},
&Package{Name: "app", Version: "1.0", Architecture: "s390", PreDepends: []string{"dpkg >= 1.6)"}, Depends: []string{"lib (>> 0.9)", "data (>= 1.0)"}}, &Package{Name: "app", Version: "1.0", Architecture: "s390", PreDepends: []string{"dpkg >= 1.6)"}, Depends: []string{"lib (>> 0.9)", "data (>= 1.0)"}},
&Package{Name: "aa", Version: "2.0-1", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}}, &Package{Name: "aa", Version: "2.0-1", Architecture: "i386", PreDepends: []string{"dpkg (>= 1.6)"}},
&Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "amd64", Provides: []string{"package-installer"}}, &Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "amd64", Source: "dpkg", Provides: []string{"package-installer"}},
&Package{Name: "libx", Version: "1.5", Architecture: "arm", PreDepends: []string{"dpkg (>= 1.6)"}}, &Package{Name: "libx", Version: "1.5", Architecture: "arm", Source: "libx", PreDepends: []string{"dpkg (>= 1.6)"}},
&Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "arm", Provides: []string{"package-installer"}}, &Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "arm", Source: "dpkg", Provides: []string{"package-installer"}},
&Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "source", SourceArchitecture: "any"}, &Package{Name: "dpkg", Version: "1.6.1-3", Architecture: "source", SourceArchitecture: "any"},
&Package{Name: "dpkg", Version: "1.7", Architecture: "source", SourceArchitecture: "any"},
} }
for _, p := range s.packages { for _, p := range s.packages {
s.il.Add(p) s.il.Add(p)
@@ -111,14 +112,14 @@ func (s *PackageListSuite) TestRemoveWhenIndexed(c *C) {
for i, p := range s.il.packagesIndex { for i, p := range s.il.packagesIndex {
names[i] = p.Name names[i] = p.Name
} }
c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "dpkg", "libx", "mailer"}) c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "dpkg", "dpkg", "libx", "mailer"})
s.il.Remove(s.packages[4]) s.il.Remove(s.packages[4])
names = make([]string, s.il.Len()) names = make([]string, s.il.Len())
for i, p := range s.il.packagesIndex { for i, p := range s.il.packagesIndex {
names[i] = p.Name names[i] = p.Name
} }
c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "dpkg", "libx"}) c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "dpkg", "dpkg", "libx"})
c.Check(s.il.providesIndex["mail-agent"], DeepEquals, []*Package{}) c.Check(s.il.providesIndex["mail-agent"], DeepEquals, []*Package{})
s.il.Remove(s.packages[9]) s.il.Remove(s.packages[9])
@@ -126,7 +127,7 @@ func (s *PackageListSuite) TestRemoveWhenIndexed(c *C) {
for i, p := range s.il.packagesIndex { for i, p := range s.il.packagesIndex {
names[i] = p.Name names[i] = p.Name
} }
c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "libx"}) c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "dpkg", "libx"})
c.Check(s.il.providesIndex["package-installer"], HasLen, 2) c.Check(s.il.providesIndex["package-installer"], HasLen, 2)
s.il.Remove(s.packages[1]) s.il.Remove(s.packages[1])
@@ -134,7 +135,7 @@ func (s *PackageListSuite) TestRemoveWhenIndexed(c *C) {
for i, p := range s.il.packagesIndex { for i, p := range s.il.packagesIndex {
names[i] = p.Name names[i] = p.Name
} }
c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "libx"}) c.Check(names, DeepEquals, []string{"aa", "app", "app", "app", "app", "data", "dpkg", "dpkg", "dpkg", "libx"})
c.Check(s.il.providesIndex["package-installer"], DeepEquals, []*Package{s.packages[11]}) c.Check(s.il.providesIndex["package-installer"], DeepEquals, []*Package{s.packages[11]})
} }
@@ -174,7 +175,7 @@ func (s *PackageListSuite) TestAppend(c *C) {
err := s.list.Append(s.il) err := s.list.Append(s.il)
c.Check(err, IsNil) c.Check(err, IsNil)
c.Check(s.list.Len(), Equals, 15) c.Check(s.list.Len(), Equals, 16)
list := NewPackageList() list := NewPackageList()
list.Add(s.p4) list.Add(s.p4)
@@ -233,6 +234,16 @@ func (s *PackageListSuite) TestVerifyDependencies(c *C) {
c.Check(missing, DeepEquals, []Dependency{Dependency{Pkg: "lib", Relation: VersionGreater, Version: "0.9", Architecture: "arm"}, c.Check(missing, DeepEquals, []Dependency{Dependency{Pkg: "lib", Relation: VersionGreater, Version: "0.9", Architecture: "arm"},
Dependency{Pkg: "mail-agent", Relation: VersionDontCare, Version: "", Architecture: "arm"}}) Dependency{Pkg: "mail-agent", Relation: VersionDontCare, Version: "", Architecture: "arm"}})
missing, err = s.il.VerifyDependencies(DepFollowSource, []string{"i386", "amd64"}, s.il)
c.Check(err, IsNil)
c.Check(missing, DeepEquals, []Dependency{Dependency{Pkg: "lib", Relation: VersionGreater, Version: "0.9", Architecture: "amd64"}})
missing, err = s.il.VerifyDependencies(DepFollowSource, []string{"arm"}, s.il)
c.Check(err, IsNil)
c.Check(missing, DeepEquals, []Dependency{Dependency{Pkg: "libx", Relation: VersionEqual, Version: "1.5", Architecture: "source"}})
_, err = s.il.VerifyDependencies(0, []string{"i386", "amd64", "s390"}, s.il) _, err = s.il.VerifyDependencies(0, []string{"i386", "amd64", "s390"}, s.il)
c.Check(err, ErrorMatches, "unable to process package app-1.0_s390:.*") c.Check(err, ErrorMatches, "unable to process package app-1.0_s390:.*")