From d2332e64528e2f0df1795793ed5741543f57b278 Mon Sep 17 00:00:00 2001 From: 5hir0kur0 <12101162+5hir0kur0@users.noreply.github.com> Date: Tue, 6 Aug 2024 13:48:06 +0900 Subject: [PATCH] Log a warning for errors in MatchesDependency --- deb/package.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/deb/package.go b/deb/package.go index b1ef3f0d..82ac7885 100644 --- a/deb/package.go +++ b/deb/package.go @@ -10,6 +10,7 @@ import ( "github.com/aptly-dev/aptly/aptly" "github.com/aptly-dev/aptly/utils" + "github.com/rs/zerolog/log" ) // Package is single instance of Debian package @@ -390,7 +391,11 @@ func (p *Package) MatchesDependency(dep Dependency) bool { return false } - if providesDep, _ := p.providesDependency(dep); providesDep { // Is ignoring errors the right thing to do here? + providesDep, err := p.providesDependency(dep) + if err != nil { + log.Warn().Err(err).Msg("Error while checking if package provides dependency") + } + if providesDep { return true }