CI/corstone: remove debug-tweaks usage

debug-tweaks is useful in testing and internal usage, but is a massive
security hole (as it allow password-less root login).  Remove the
default enablement on machine files and in kas base yml.

Signed-off-by: Jon Mason <jon.mason@arm.com>

ci/base.yml

@@ -30,7 +30,6 @@ local_conf_header:
   setup: |
     PACKAGE_CLASSES = "package_ipk"
     PACKAGECONFIG:remove:pn-qemu-system-native = "gtk+ sdl"
-    EXTRA_IMAGE_FEATURES:append = " debug-tweaks"
     PACKAGECONFIG:append:pn-perf = " coresight"
     INHERIT += "rm_work"
     DISTRO_FEATURES:remove = "ptest"

ci/testimage.yml

@@ -3,6 +3,7 @@ header:
 
 local_conf_header:
   testimage: |
+    EXTRA_IMAGE_FEATURES:append = " debug-tweaks"
     IMAGE_CLASSES += "testimage"
     TESTIMAGE_AUTO = "1"
   kvm: |

meta-arm-bsp/conf/machine/corstone500.conf

@@ -17,7 +17,6 @@ PREFERRED_VERSION_linux-yocto ?= "6.1%"
 EXTRA_IMAGEDEPENDS += "trusted-firmware-a u-boot"
 
 IMAGE_CLASSES += "wic_nopt"
-IMAGE_FEATURES += "debug-tweaks"
 IMAGE_FSTYPES:forcevariable = "cpio.gz squashfs wic wic.nopt"
 
 SERIAL_CONSOLES = "115200;ttyAMA0"

meta-arm-bsp/recipes-bsp/images/corstone1000-initramfs-image.bb

@@ -15,8 +15,6 @@ inherit core-image
 
 inherit image-buildinfo
 
-IMAGE_FEATURES += "debug-tweaks"
-
 #package management is not supported in corstone1000
 IMAGE_FEATURES:remove = "package-management"