mirrors/meta-openembedded
1
0
Fork 0
mirror of https://github.com/openembedded/meta-openembedded.git synced 2026-08-25 05:21:31 +00:00
Code Issues Projects Releases Wiki Activity

postgresql: drop bashisms from ptest runner

Browse Source 
run-ptest has a #!/bin/sh shebang but used two constructs that are not
available in the target /bin/sh (dash), so the suite died immediately
after starting the server and reported no test results at all:

  run-ptest: line 54: stdbuf: not found
  run-ptest: line 58: syntax error: bad substitution
  ERROR: Exit status is 2

${PIPESTATUS[0]} is a bash array reference; dash has no PIPESTATUS and
fails with "bad substitution". stdbuf is coreutils-only and is not
guaranteed to be installed on the target.

Capture pg_regress output to a temporary file and use $? directly
instead of piping live into sed, which removes the need for both
PIPESTATUS and stdbuf while keeping the same PASS:/FAIL: translation.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
This commit is contained in:
Khem Raj
2026-08-17 20:38:30 +02:00
committed by Khem Raj
parent 176c2485b9
commit 075b833d3e
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta-oe/recipes-dbs/postgresql/files/run-ptest
+14 -7
View File
@@ -37,24 +37,31 @@ mkdir -p "${TESTDIR}/testtablespace"
chmod 0700 "${TESTDIR}/testtablespace"
chown postgres:postgres "${TESTDIR}/testtablespace"
# Disable set -e before the pipe so we can capture PIPESTATUS
# Disable set -e so we can capture the regression run's exit status
set +e
# Run the regression tests.
# Run the regression tests, capturing output to a plain file instead of
# piping live into sed: ${PIPESTATUS[0]} is a bashism this script's
# "#!/bin/sh" shebang can't rely on (target /bin/sh is dash, which has no
# PIPESTATUS array and fails with "bad substitution"), and batching
# through a file avoids needing stdbuf, which isn't guaranteed installed.
# --dlpath points to the standard PostgreSQL package library directory
# where regress.so and contrib modules (autoinc.so, refint.so, etc.)
# are installed, so that CREATE FUNCTION ... AS tests can locate them.
REGRESS_LOG=$(mktemp /tmp/postgresql-ptest.XXXXXX)
su - postgres -c "cd ${TESTDIR} && \
${TESTDIR}/pg_regress \
--inputdir=. \
--bindir=${PGBIN} \
--dlpath=${PKGLIBDIR} \
--max-concurrent-tests=20 \
--schedule=parallel_schedule" 2>&1 | \
stdbuf -oL sed -n \
-e 's/^ok [0-9]\+\s\+[+* ]\?\s*/PASS: /p' \
-e 's/^not ok [0-9]\+\s\+[+* ]\?\s*/FAIL: /p'
RESULT=${PIPESTATUS[0]}
--schedule=parallel_schedule" > "${REGRESS_LOG}" 2>&1
RESULT=$?
sed -n \
-e 's/^ok [0-9]\+\s\+[+* ]\?\s*/PASS: /p' \
-e 's/^not ok [0-9]\+\s\+[+* ]\?\s*/FAIL: /p' "${REGRESS_LOG}"
rm -f "${REGRESS_LOG}"
if [ "${RESULT}" = "0" ]; then
echo "PASS: all tests passed"