mirror of
https://github.com/openembedded/meta-openembedded.git
synced 2026-06-07 03:29:59 +00:00
dlt-daemon: fix sign-conversion warning in dlt_timer_conn_types array type
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
This commit is contained in:
@@ -0,0 +1,27 @@
|
||||
daemon: fix sign-conversion warning in dlt_timer_conn_types array type
|
||||
|
||||
Change dlt_timer_conn_types from char[] to DltConnectionType[] to match
|
||||
the actual type of values stored in the array.
|
||||
|
||||
This was silently working on arm64 because char is unsigned by default on
|
||||
that architecture, making it compatible with DltConnectionType (an unsigned
|
||||
enum). On x86_64, char is signed by default, causing an implicit signed-to-
|
||||
unsigned conversion when passing array elements to dlt_connection_create(),
|
||||
which triggered -Wsign-conversion and broke the build.
|
||||
|
||||
The fix corrects the array's declared type to match its contents, making the
|
||||
code portable regardless of the platform's char signedness.
|
||||
|
||||
Upstream-Status: Pending
|
||||
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
|
||||
--- a/src/daemon/dlt-daemon.c
|
||||
+++ b/src/daemon/dlt-daemon.c
|
||||
@@ -140,7 +140,7 @@ int g_signo = 0;
|
||||
/* used for value from conf file */
|
||||
static int value_length = 1024;
|
||||
|
||||
-static char dlt_timer_conn_types[DLT_TIMER_UNKNOWN + 1] = {
|
||||
+static DltConnectionType dlt_timer_conn_types[DLT_TIMER_UNKNOWN + 1] = {
|
||||
[DLT_TIMER_PACKET] = DLT_CONNECTION_ONE_S_TIMER,
|
||||
[DLT_TIMER_ECU] = DLT_CONNECTION_SIXTY_S_TIMER,
|
||||
#ifdef DLT_SYSTEMD_WATCHDOG_ENABLE
|
||||
@@ -25,6 +25,7 @@ SRC_URI = "git://github.com/COVESA/${BPN}.git;protocol=https;branch=master \
|
||||
file://0001-CMakeLists.txt-make-CONFIGURATION_FILES_DIR-aligned.patch \
|
||||
file://0001-warnings-Fix-clang-generated-warnings.patch \
|
||||
file://0001-dlt-daemon.c-fix-wrong-len.patch \
|
||||
file://char_conversion.patch \
|
||||
"
|
||||
SRCREV = "f595ea29d1007ca1c3b2d1fd3a88adf7d3db6320"
|
||||
|
||||
|
||||
Reference in New Issue
Block a user