mirrors/meta-openembedded
1
0
Fork 0
mirror of https://github.com/openembedded/meta-openembedded.git synced 2026-06-14 05:49:57 +00:00
Code Issues Projects Releases Wiki Activity

sysbench: fix memory test

Browse Source 
In sysbench version 0.4, the tmp variable used by the memory test to
execute requests is optimized by the compiler. Caching mechanism reduces
the direct accesses to the memory increasing the transfer speed. This
leads to false timing estimations that considerably affect read and
also random write operations.

In sysbench version 1, this issue is fixed adding the volatile modifier
to the tmp variable. This prevents compiler optimizations forcing a direct
access to the memory.

The final result is a realistic transfer speed measurement.

Signed-off-by: massimo toscanelli <massimo.toscanelli@leica-geosystems.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 59cce5ad16)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
This commit is contained in:
massimo toscanelli
2021-07-08 12:58:51 +00:00
committed by Armin Kuster
parent 82cca6d4ed
commit 6a7ba8f7f2
2 changed files with 43 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta-oe/recipes-benchmark/sysbench/sysbench/0001-Adding-volatile-modifier-to-tmp-variable-in-memory-t.patch
+40
View File
@@ -0,0 +1,40 @@
From c1ebf893e32a0a77e820484d48a903523fef7c1b Mon Sep 17 00:00:00 2001
From: Vasily Tarasov <tarasov@vasily.name>
Date: Fri, 10 Jun 2016 14:33:48 -0400
Subject: [PATCH] Adding volatile modifier to tmp variable in memory test
Issue explanation:
./sysbench/sysbench --test=memory --num-threads=16 \
--memory-block-size=268435456 \
--memory-total-size=137438953472 \
--memory-oper=read \
--memory-access-mode=seq \
--memory-scope=local run
Without this commit the time to run the above command is 0.0004 seconds.
With this commit the time is greater than 3 seconds. Essentially,
without the volatile modifier, the compiler optimizes read access so
that no real access happens.
Upstream-Status: Backport [part of v1.0.0 https://github.com/akopytov/sysbench/commit/8753cb93be4c0b81a20b704ced91e7a422da52b1]
(cherry picked from commit 8753cb93be4c0b81a20b704ced91e7a422da52b1)
Signed-off-by: massimo toscanelli <massimo.toscanelli@leica-geosystems.com>
---
sysbench/tests/memory/sb_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysbench/tests/memory/sb_memory.c b/sysbench/tests/memory/sb_memory.c
index 2e8998f..7d22bb9 100644
--- a/sysbench/tests/memory/sb_memory.c
+++ b/sysbench/tests/memory/sb_memory.c
@@ -244,7 +244,7 @@ sb_request_t memory_get_request(int tid)
int memory_execute_request(sb_request_t *sb_req, int thread_id)
{
sb_mem_request_t *mem_req = &sb_req->u.mem_request;
- int tmp = 0;
+ volatile int tmp = 0;
int idx;
int *buf, *end;
log_msg_t msg;
meta-oe/recipes-benchmark/sysbench/sysbench_0.4.12.bb
+3 -1
View File
@@ -8,7 +8,9 @@ inherit autotools
# The project has moved from Sourceforge to Launchpad, to Github. Use the source tarball from
# Launchpad until the next release is available from Github.
SRC_URI = "https://launchpad.net/ubuntu/+archive/primary/+files/${BPN}_${PV}.orig.tar.gz"
SRC_URI = "https://launchpad.net/ubuntu/+archive/primary/+files/${BPN}_${PV}.orig.tar.gz \
file://0001-Adding-volatile-modifier-to-tmp-variable-in-memory-t.patch \
"
SRC_URI[md5sum] = "3a6d54fdd3fe002328e4458206392b9d"
SRC_URI[sha256sum] = "83fa7464193e012c91254e595a89894d8e35b4a38324b52a5974777e3823ea9e"