mirrors/meta-openembedded
1
0 Fork 0
mirror of https://github.com/openembedded/meta-openembedded.git synced 2026-11-13 03:37:15 +00:00
Code Issues Projects Releases Wiki Activity

gflags: Fix buildpaths QA warning for gflags_completions.h

Browse Source 
The usage example in gflags_completions.h hardcodes
/home/build/eng/bash/bash_completions.sh, a path from the original build
environment. It matches the HOME of the yoe build container, so
do_package_qa reports:

  File /usr/include/gflags/gflags_completions.h in package gflags-dev
  contains a reference to the build host HOME directory. [buildpaths]

Point the example at the installed gflags_completions.sh instead.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
This commit is contained in:
Khem Raj committed 2026-10-29 19:59:13 -07:00
1 parent 4fd8d4a415
commit ffd143385c
2 files changed
+40 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

meta-oe/recipes-support/gflags/gflags/0001-Use-an-installed-path-in-the-gflags_completions.h-us.patch
+37
View File
@@ -0,0 +1,37 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Khem Raj <raj.khem@gmail.com>
Date: Thu, 29 Oct 2026 07:04:28 -0700
Subject: [PATCH] Use an installed path in the gflags_completions.h usage
example
The example .bashrc line in gflags_completions.h points at
/home/build/eng/bash/bash_completions.sh, a path from the original build
environment that names a script gflags does not ship. Refer to the
installed gflags_completions.sh instead, matching the example in
gflags_completions.sh itself.
The old path also trips reproducibility checks that look for build-host
home directories in installed files, e.g. Yocto's buildpaths QA check:
File /usr/include/gflags/gflags_completions.h in package gflags-dev
contains a reference to the build host HOME directory. [buildpaths]
Upstream-Status: Pending
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
src/gflags_completions.h.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gflags_completions.h.in b/src/gflags_completions.h.in
index 177b8d2..35d76dc 100644
--- a/src/gflags_completions.h.in
+++ b/src/gflags_completions.h.in
@@ -89,7 +89,7 @@
/*
$ complete -o bashdefault -o default -o nospace -C \
- '/home/build/eng/bash/bash_completions.sh --tab_completion_columns $COLUMNS' \
+ '/usr/local/bin/gflags_completions.sh --tab_completion_columns $COLUMNS' \
time env binary_name another_binary [...]
*/
meta-oe/recipes-support/gflags/gflags_2.3.1.bb
+3 -1
View File
@@ -3,7 +3,9 @@ HOMEPAGE = "https://github.com/gflags/gflags"
LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM = "file://COPYING.txt;md5=c80d1a3b623f72bb85a4c75b556551df"
SRC_URI = "git://github.com/gflags/gflags.git;branch=main;protocol=https;tag=v${PV}"
SRC_URI = "git://github.com/gflags/gflags.git;branch=main;protocol=https;tag=v${PV} \
file://0001-Use-an-installed-path-in-the-gflags_completions.h-us.patch \
"
SRCREV = "8f30ebfb2b206a8bd3a97ffe3b59009a952343e6"
inherit cmake