mirror of
https://git.yoctoproject.org/meta-ti
synced 2026-07-17 06:48:07 +00:00
Koen Kooi
df83a59b6b
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
41 lines
1.4 KiB
Diff
41 lines
1.4 KiB
Diff
From 25ad0cb4cfe9597474d8cda839d5adedc9412201 Mon Sep 17 00:00:00 2001
|
|
From: Daniel Mack <zonque@gmail.com>
|
|
Date: Wed, 1 Aug 2012 10:16:53 +0200
|
|
Subject: [PATCH 57/70] ALSA: snd-usb: fix clock source validity index
|
|
|
|
commit aff252a848ce21b431ba822de3dab9c4c94571cb upstream.
|
|
|
|
uac_clock_source_is_valid() uses the control selector value to access
|
|
the bmControls bitmap of the clock source unit. This is wrong, as
|
|
control selector values start from 1, while the bitmap uses all
|
|
available bits.
|
|
|
|
In other words, "Clock Validity Control" is stored in D3..2, not D5..4
|
|
of the clock selector unit's bmControls.
|
|
|
|
Signed-off-by: Daniel Mack <zonque@gmail.com>
|
|
Reported-by: Andreas Koch <andreas@akdesigninc.com>
|
|
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
|
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
|
|
---
|
|
sound/usb/clock.c | 3 ++-
|
|
1 files changed, 2 insertions(+), 1 deletions(-)
|
|
|
|
diff --git a/sound/usb/clock.c b/sound/usb/clock.c
|
|
index 379baad..5e634a2 100644
|
|
--- a/sound/usb/clock.c
|
|
+++ b/sound/usb/clock.c
|
|
@@ -111,7 +111,8 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, int source_id)
|
|
return 0;
|
|
|
|
/* If a clock source can't tell us whether it's valid, we assume it is */
|
|
- if (!uac2_control_is_readable(cs_desc->bmControls, UAC2_CS_CONTROL_CLOCK_VALID))
|
|
+ if (!uac2_control_is_readable(cs_desc->bmControls,
|
|
+ UAC2_CS_CONTROL_CLOCK_VALID - 1))
|
|
return 1;
|
|
|
|
err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR,
|
|
--
|
|
1.7.7.6
|
|
|