mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-06-01 13:09:50 +00:00
Code Issues Projects Releases Wiki Activity

psplash: new patch to fix segfault

Browse Source 
This fixes a segmentation fault when passing -a without
an argument.

Fixes [YOCTO #2903]

(From OE-Core rev: f5b8ba5e51ac41cf375119a88083617f667a85d5)

Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Scott Garman
2012-12-22 21:52:27 -08:00
committed by Richard Purdie
parent 2ccb03f9b7
commit 01c1421270
2 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta/recipes-core/psplash/files/psplash_fix_bad_arg_segfault.patch
+22
View File
@@ -0,0 +1,22 @@
Fix segmentation fault when passing -a without angle value.
When psplash -a is called instead of psplash -a<angle value>, it will
cause a segmentation fault by calling an out of bound argv[].
Upstream-Status: Accepted
Needed for denzil since we're not upgrading the recipe.
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
diff -urN git.orig/psplash.c git/psplash.c
--- git.orig/psplash.c 2012-12-22 21:28:05.830631789 -0800
+++ git/psplash.c 2012-12-22 21:29:54.962633330 -0800
@@ -219,7 +219,7 @@
if (!strcmp(argv[i],"-a") || !strcmp(argv[i],"--angle"))
{
- if (++i > argc) goto fail;
+ if (++i >= argc) goto fail;
angle = atoi(argv[i]);
continue;
}
meta/recipes-core/psplash/psplash_git.bb
+2 -1
View File
@@ -7,10 +7,11 @@ LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85b
SRCREV = "e05374aae945bcfc6d962ed0d7b2774b77987e1d"
PV = "0.1+git${SRCPV}"
PR = "r2"
PR = "r3"
SRC_URI = "git://git.yoctoproject.org/${BPN};protocol=git \
file://psplash-init \
file://psplash_fix_bad_arg_segfault.patch \
${SPLASH_IMAGES}"
SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"