mirror of
https://git.yoctoproject.org/poky
synced 2026-05-08 05:09:24 +00:00
insane.bbclass: fix new override syntax migration
A few variables and messages were not migrated over to the new override syntax (_ to :). Let's fix that. (From OE-Core rev: c595d6040d2e0ef94d7da043b41226e90dddf318) Signed-off-by: Quentin Schulz <foss@0leil.net> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
9fe8f88026
commit
3ae80177fb
@@ -835,11 +835,11 @@ def package_qa_check_deps(pkg, pkgdest, d):
|
||||
try:
|
||||
rvar = bb.utils.explode_dep_versions2(localdata.getVar(var) or "")
|
||||
except ValueError as e:
|
||||
bb.fatal("%s_%s: %s" % (var, pkg, e))
|
||||
bb.fatal("%s:%s: %s" % (var, pkg, e))
|
||||
for dep in rvar:
|
||||
for v in rvar[dep]:
|
||||
if v and not v.startswith(('< ', '= ', '> ', '<= ', '>=')):
|
||||
error_msg = "%s_%s is invalid: %s (%s) only comparisons <, =, >, <=, and >= are allowed" % (var, pkg, dep, v)
|
||||
error_msg = "%s:%s is invalid: %s (%s) only comparisons <, =, >, <=, and >= are allowed" % (var, pkg, dep, v)
|
||||
package_qa_handle_error("dep-cmp", error_msg, d)
|
||||
|
||||
check_valid_deps('RDEPENDS')
|
||||
@@ -888,7 +888,7 @@ def package_qa_check_expanded_d(package, d, messages):
|
||||
expanded_d = d.getVar('D')
|
||||
|
||||
for var in 'FILES','pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm':
|
||||
bbvar = d.getVar(var + "_" + package) or ""
|
||||
bbvar = d.getVar(var + ":" + package) or ""
|
||||
if expanded_d in bbvar:
|
||||
if var == 'FILES':
|
||||
package_qa_add_message(messages, "expanded-d", "FILES in %s recipe should not contain the ${D} variable as it references the local build directory not the target filesystem, best solution is to remove the ${D} reference" % package)
|
||||
@@ -1325,10 +1325,10 @@ python () {
|
||||
if prog.search(pn):
|
||||
package_qa_handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d)
|
||||
|
||||
# Some people mistakenly use DEPENDS_${PN} instead of DEPENDS and wonder
|
||||
# Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder
|
||||
# why it doesn't work.
|
||||
if (d.getVar(d.expand('DEPENDS_${PN}'))):
|
||||
package_qa_handle_error("pkgvarcheck", "recipe uses DEPENDS_${PN}, should use DEPENDS", d)
|
||||
if (d.getVar(d.expand('DEPENDS:${PN}'))):
|
||||
package_qa_handle_error("pkgvarcheck", "recipe uses DEPENDS:${PN}, should use DEPENDS", d)
|
||||
|
||||
issues = []
|
||||
if (d.getVar('PACKAGES') or "").split():
|
||||
|
||||
Reference in New Issue
Block a user