mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-05-08 17:19:20 +00:00
Code Issues Projects Releases Wiki Activity

insane: check for RUNPATH as well as RPATH

Browse Source 
Since oe-core 66f8a7 merged in 2023[1], ld sets DT_RUNPATH instead of
DT_RPATH when -rpath is specified, which we don't check for.

Update the insane tests to look at both RPATH and RUNPATH.

[1] oe-core 66f8a745668a067d8d763fa2af3e65f26c9c1ebe

(From OE-Core rev: d6c5076d179a3d5ebb74b719ec4d523c197c1918)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Ross Burton
2024-10-10 17:06:18 +01:00
committed by Richard Purdie
parent 27ab030dc0
commit 876d319f73
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meta/classes-global/insane.bbclass
+4 -4
View File
@@ -115,7 +115,7 @@ def package_qa_check_libexec(path,name, d, elf):
oe.qa.handle_error("libexec", "%s: %s is using libexec please relocate to %s" % (name, package_qa_clean_path(path, d, name), libexec), d)
QAPATHTEST[rpaths] = "package_qa_check_rpath"
def package_qa_check_rpath(file,name, d, elf):
def package_qa_check_rpath(file, name, d, elf):
"""
Check for dangerous RPATHs
"""
@@ -127,14 +127,14 @@ def package_qa_check_rpath(file,name, d, elf):
phdrs = elf.run_objdump("-p", d)
import re
rpath_re = re.compile(r"\s+RPATH\s+(.*)")
rpath_re = re.compile(r"\s+(?:RPATH|RUNPATH)\s+(.*)")
for line in phdrs.split("\n"):
m = rpath_re.match(line)
if m:
rpath = m.group(1)
for dir in bad_dirs:
if dir in rpath:
oe.qa.handle_error("rpaths", "package %s contains bad RPATH %s in file %s" % (name, rpath, file), d)
oe.qa.handle_error("rpaths", "%s: %s contains bad RPATH %s" % (name, package_qa_clean_path(file, d, name), rpath), d)
QAPATHTEST[useless-rpaths] = "package_qa_check_useless_rpaths"
def package_qa_check_useless_rpaths(file, name, d, elf):
@@ -153,7 +153,7 @@ def package_qa_check_useless_rpaths(file, name, d, elf):
phdrs = elf.run_objdump("-p", d)
import re
rpath_re = re.compile(r"\s+RPATH\s+(.*)")
rpath_re = re.compile(r"\s+(?:RPATH|RUNPATH)\s+(.*)")
for line in phdrs.split("\n"):
m = rpath_re.match(line)
if m: