1
0
mirror of https://git.yoctoproject.org/poky synced 2026-05-08 17:19:20 +00:00

patchelf: replace a rejected patch with an equivalent uninative.bbclass tweak

This was the original reason to add the patch:
https://git.openembedded.org/openembedded-core/commit/?id=18efcbcb896239c64fedd009ce57f3f0c668cbc0

and this is the upstream discussion which suggests handling
read-only files explicitly outside of patchelf:
https://github.com/NixOS/patchelf/pull/89

(From OE-Core rev: 728775c87a7e35a03408675ce1c7a8cd061b2fda)

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Alexander Kanavin
2022-08-11 21:58:05 +02:00
committed by Richard Purdie
parent 51aa1c66dd
commit fd65379613
3 changed files with 2 additions and 64 deletions
+2
View File
@@ -173,5 +173,7 @@ python uninative_changeinterp () {
if not elf.isDynamic():
continue
os.chmod(f, s[stat.ST_MODE] | stat.S_IWUSR)
subprocess.check_output(("patchelf-uninative", "--set-interpreter", d.getVar("UNINATIVE_LOADER"), f), stderr=subprocess.STDOUT)
os.chmod(f, s[stat.ST_MODE])
}
@@ -1,63 +0,0 @@
From 38b3d65f4a79d39ad9cdf841f2b3b29fd0c961ca Mon Sep 17 00:00:00 2001
From: Fabio Berton <fabio.berton@ossystems.com.br>
Date: Fri, 9 Sep 2016 16:00:42 -0300
Subject: [PATCH] handle read-only files
Patch from:
https://github.com/darealshinji/patchelf/commit/40e66392bc4b96e9b4eda496827d26348a503509
Upstream-Status: Denied [https://github.com/NixOS/patchelf/pull/89]
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
src/patchelf.cc | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/patchelf.cc b/src/patchelf.cc
index 49accae..fb6c7ed 100644
--- a/src/patchelf.cc
+++ b/src/patchelf.cc
@@ -378,8 +378,16 @@ void ElfFile<ElfFileParamNames>::sortShdrs()
static void writeFile(const std::string & fileName, const FileContents & contents)
{
+ struct stat st;
+
debug("writing %s\n", fileName.c_str());
+ if (stat(fileName.c_str(), &st) != 0)
+ error("stat");
+
+ if (chmod(fileName.c_str(), 0600) != 0)
+ error("chmod");
+
int fd = open(fileName.c_str(), O_CREAT | O_TRUNC | O_WRONLY | O_BINARY, 0777);
if (fd == -1)
error("open");
@@ -395,8 +403,6 @@ static void writeFile(const std::string & fileName, const FileContents & content
bytesWritten += portion;
}
- if (close(fd) >= 0)
- return;
/*
* Just ignore EINTR; a retry loop is the wrong thing to do.
*
@@ -405,9 +411,11 @@ static void writeFile(const std::string & fileName, const FileContents & content
* http://utcc.utoronto.ca/~cks/space/blog/unix/CloseEINTR
* https://sites.google.com/site/michaelsafyan/software-engineering/checkforeintrwheninvokingclosethinkagain
*/
- if (errno == EINTR)
- return;
- error("close");
+ if ((close(fd) < 0) && errno != EINTR)
+ error("close");
+
+ if (chmod(fileName.c_str(), st.st_mode) != 0)
+ error("chmod");
}
--
2.30.2
@@ -5,7 +5,6 @@ HOMEPAGE = "https://github.com/NixOS/patchelf"
LICENSE = "GPL-3.0-only"
SRC_URI = "git://github.com/NixOS/patchelf;protocol=https;branch=master \
file://handle-read-only-files.patch \
"
SRCREV = "49008002562355b0e35075cbc1c42c645ff04e28"