vincent/aptly
1
0
Fork 0
mirror of https://github.com/aptly-dev/aptly.git synced 2026-06-07 05:42:42 +00:00
Code Issues Projects Releases Wiki Activity

fix apiReposCopyPackage getting corrupt file name

Browse Source 
it seems c.Params.ByName("file") should not be used
inside maybeRunTaskInBackground, as the content may be corrupted sometimes.
This commit is contained in:
André Roth
2024-07-17 23:13:45 +02:00
parent 440c3debdc
commit 49184c9163
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/repos.go
+3 -2
View File
@@ -419,6 +419,7 @@ func apiReposPackageFromDir(c *gin.Context) {
func apiReposCopyPackage(c *gin.Context) {
dstRepoName := c.Params.ByName("name")
srcRepoName := c.Params.ByName("src")
fileName := c.Params.ByName("file")
jsonBody := struct {
WithDeps bool `json:"with-deps,omitempty"`
@@ -513,9 +514,9 @@ func apiReposCopyPackage(c *gin.Context) {
// srcList.Filter|FilterWithProgress only accept query list
queries := make([]deb.PackageQuery, 1)
queries[0], err = query.Parse(c.Params.ByName("file"))
queries[0], err = query.Parse(fileName)
if err != nil {
return &task.ProcessReturnValue{Code: http.StatusUnprocessableEntity, Value: nil}, fmt.Errorf("unable to parse query: %s", err)
return &task.ProcessReturnValue{Code: http.StatusUnprocessableEntity, Value: nil}, fmt.Errorf("unable to parse query '%s': %s", fileName, err)
}
toProcess, err := srcList.FilterWithProgress(queries, jsonBody.WithDeps, dstList, context.DependencyOptions(), architecturesList, context.Progress())