vincent/aptly
1
0
Fork 0
mirror of https://github.com/aptly-dev/aptly.git synced 2026-01-12 03:21:33 +00:00
Code Issues Projects Releases Wiki Activity

fix failing build on hosts with wildcard dns

Browse Source 
on hosts which have wildcard dns domains in their local domain search
list, builds failed because "nosuch.host" could actually be resolved.

Since ".host" isn't a recommended TLD by RFC2606, we use ".invalid" now.
And since this is not enough to fix the problem, we use now absoulte
domain names (having a '.' at the end)
This commit is contained in:
Jens Reinsberger
2023-11-08 15:38:42 +01:00
committed by André Roth
parent 5353890b24
commit 4bc2180eed
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
http/download_test.go
View File

@@ -115,7 +115,7 @@ func (s *DownloaderSuite) TestDownload404(c *C) {
}
func (s *DownloaderSuite) TestDownloadConnectError(c *C) {
c.Assert(s.d.Download(s.ctx, "http://nosuch.host/", s.tempfile.Name()),
c.Assert(s.d.Download(s.ctx, "http://nosuch.host.invalid./", s.tempfile.Name()),
ErrorMatches, ".*no such host")
}
@@ -150,7 +150,7 @@ func (s *DownloaderSuite) TestGetLength404(c *C) {
}
func (s *DownloaderSuite) TestGetLengthConnectError(c *C) {
_, err := s.d.GetLength(s.ctx, "http://nosuch.host/")
_, err := s.d.GetLength(s.ctx, "http://nosuch.host.invalid./")
c.Assert(err, ErrorMatches, ".*no such host")
}

4
http/grab_test.go
View File

@@ -106,7 +106,7 @@ func (s *GrabDownloaderSuite) TestDownload404(c *C) {
}
func (s *GrabDownloaderSuite) TestDownloadConnectError(c *C) {
c.Assert(s.d.Download(s.ctx, "http://nosuch.host/", s.tempfile.Name()),
c.Assert(s.d.Download(s.ctx, "http://nosuch.host.invalid./", s.tempfile.Name()),
ErrorMatches, ".*no such host")
}
@@ -130,7 +130,7 @@ func (s *GrabDownloaderSuite) TestGetLength404(c *C) {
}
func (s *GrabDownloaderSuite) TestGetLengthConnectError(c *C) {
_, err := s.d.GetLength(s.ctx, "http://nosuch.host/")
_, err := s.d.GetLength(s.ctx, "http://nosuch.host.invalid./")
c.Assert(err, ErrorMatches, ".*no such host")
}