vincent/aptly
1
0
Fork 0
mirror of https://github.com/aptly-dev/aptly.git synced 2026-06-04 05:10:40 +00:00
Code Issues Projects Releases Wiki Activity

Make truthy function less surprising

Browse Source
This commit is contained in:
Lorenzo Bolla
2021-12-16 14:09:46 +01:00
parent 6826efc723
commit b281819cba
2 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/api.go
+8 -3
View File
@@ -114,18 +114,23 @@ func runTaskInBackground(name string, resources []string, proc task.Process) (ta
}
func truthy(value interface{}) bool {
if value == nil {
return false
}
switch value.(type) {
case string:
switch strings.ToLower(value.(string)) {
case "y", "yes", "t", "true", "1":
case "n", "no", "f", "false", "0", "off":
return false
default:
return true
}
case int:
return value.(int) == 1
return !(value.(int) == 0)
case bool:
return value.(bool)
}
return false
return true
}
func maybeRunTaskInBackground(c *gin.Context, name string, resources []string, proc task.Process) {
api/api_test.go
+12 -6
View File
@@ -93,6 +93,14 @@ func (s *ApiSuite) TestGetVersion(c *C) {
}
func (s *ApiSuite) TestTruthy(c *C) {
c.Check(truthy("no"), Equals, false)
c.Check(truthy("n"), Equals, false)
c.Check(truthy("off"), Equals, false)
c.Check(truthy("false"), Equals, false)
c.Check(truthy("0"), Equals, false)
c.Check(truthy(false), Equals, false)
c.Check(truthy(0), Equals, false)
c.Check(truthy("y"), Equals, true)
c.Check(truthy("yes"), Equals, true)
c.Check(truthy("t"), Equals, true)
@@ -101,11 +109,9 @@ func (s *ApiSuite) TestTruthy(c *C) {
c.Check(truthy(true), Equals, true)
c.Check(truthy(1), Equals, true)
c.Check(truthy("no"), Equals, false)
c.Check(truthy("foobar"), Equals, false)
c.Check(truthy(0), Equals, false)
c.Check(truthy(-1), Equals, false)
c.Check(truthy(false), Equals, false)
c.Check(truthy(nil), Equals, false)
c.Check(truthy(gin.H{}), Equals, false)
c.Check(truthy("foobar"), Equals, true)
c.Check(truthy(-1), Equals, true)
c.Check(truthy(gin.H{}), Equals, true)
}