vincent/aptly
1
0
Fork 0
mirror of https://github.com/aptly-dev/aptly.git synced 2026-04-17 19:08:13 +00:00
Code Issues Projects Releases Wiki Activity

Make snapshot diff GET, not POST (as it doesn't change anything in the system). #168

Browse Source
This commit is contained in:
Andrey Smirnov
2015-01-24 21:51:33 +03:00
parent d828732307
commit ebea4f10a0
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/router.go
View File

@@ -65,7 +65,7 @@ func Router(c *ctx.AptlyContext) http.Handler {
root.GET("/snapshots/:name", apiSnapshotsShow)
root.GET("/snapshots/:name/packages", apiSnapshotsSearchPackages)
root.DELETE("/snapshots/:name", apiSnapshotsDrop)
root.POST("/snapshots/:name/diff/:withSnapshot", apiSnapshotsDiff)
root.GET("/snapshots/:name/diff/:withSnapshot", apiSnapshotsDiff)
}
{

2
api/snapshot.go
View File

@@ -333,7 +333,7 @@ func apiSnapshotsDrop(c *gin.Context) {
c.JSON(200, gin.H{})
}
// POST /api/snapshots/:name/diff/:name2
// GET /api/snapshots/:name/diff/:withSnapshot
func apiSnapshotsDiff(c *gin.Context) {
onlyMatching := c.Request.URL.Query().Get("onlyMatching") == "1"

8
system/t12_api/snapshots.py
View File

@@ -62,7 +62,7 @@ class SnapshotsAPITestCreateFromRepo(APITest):
self.check_equal(resp.status_code, 400)
d = self.random_name()
self.check_equal(self.upload("/api/files/" + d,
self.check_equal(self.upload("/api/files/" + d,
"libboost-program-options-dev_1.49.0.1_i386.deb").status_code, 200)
self.check_equal(self.post("/api/repos/" + repo_name + "/file/" + d).status_code, 200)
@@ -128,7 +128,7 @@ class SnapshotsAPITestSearch(APITest):
d = self.random_name()
snapshot_name = self.random_name()
self.check_equal(self.upload("/api/files/" + d,
self.check_equal(self.upload("/api/files/" + d,
"libboost-program-options-dev_1.49.0.1_i386.deb").status_code, 200)
self.check_equal(self.post("/api/repos/" + repo_name + "/file/" + d).status_code, 200)
@@ -161,7 +161,7 @@ class SnapshotsAPITestDiff(APITest):
self.check_equal(self.post("/api/repos", json={"Name": repo_name}).status_code, 201)
d = self.random_name()
self.check_equal(self.upload("/api/files/" + d,
self.check_equal(self.upload("/api/files/" + d,
"libboost-program-options-dev_1.49.0.1_i386.deb").status_code, 200)
self.check_equal(self.post("/api/repos/" + repo_name + "/file/" + d).status_code, 200)
@@ -172,7 +172,7 @@ class SnapshotsAPITestDiff(APITest):
resp = self.post("/api/snapshots", json={'Name': snapshots[1]})
self.check_equal(resp.status_code, 201)
resp = self.post("/api/snapshots/" + snapshots[0] + "/diff/" + snapshots[1])
resp = self.get("/api/snapshots/" + snapshots[0] + "/diff/" + snapshots[1])
self.check_equal(resp.status_code, 200)
self.check_subset({"Right": None}, resp.json()[0])